Skip to content

More generous OAuth timeout#9960

Open
apYdr6uxv wants to merge 1 commit into
PathOfBuildingCommunity:devfrom
apYdr6uxv:patch-1
Open

More generous OAuth timeout#9960
apYdr6uxv wants to merge 1 commit into
PathOfBuildingCommunity:devfrom
apYdr6uxv:patch-1

Conversation

@apYdr6uxv

Copy link
Copy Markdown

Description of the problem being solved:

PoB OAuth is too impatient. By the time you are through, the return server is no longer listening.

One convoluted example how you might miss the deadline:

  • Auth button opens in the default browser, but you use another one for logging into PoE
  • You have slow internet, so nothing loads fast
  • You are stopped by a Cloudflare check, who takes a while before allowing you to continue
  • You stop to read the scary OAuth warning
  • You finally return to localhost but PoB is no longer there

I have read the code comment block above this code section, explaining why it currently is 30s.
But how much more likely are those issues, compared to people like me, not being fast enough?
The OAuth rework is great; but with the current timeout, it might bring a flood of issues about this same thing.

Steps taken to verify a working solution:

  • I was one of the victims; bumped mine to 90, just to be safe

Helps with slow connections; Cloudflare checks.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant