Skip to content

Exit if bad trade leagues JSON #9961

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
LocalIdentity merged 2 commits into from
Jul 23, 2026
+6 −1
Merged

Exit if bad trade leagues JSON #9961

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
2679917
Exit if bad JSON
apYdr6uxv Jul 21, 2026
8367d13
Fix crash on table return
Jul 23, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 6 additions & 1 deletion src/Classes/TradeQueryRequests.lua
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -379,7 +379,12 @@ function TradeQueryRequestsClass:FetchLeagues(realm, callback)
end
local json_data = dkjson.decode(response.body)
if not json_data or json_data.error then
errMsg = json_data and json_data.error or "Failed to parse trade leagues JSON"
local apiError = json_data and json_data.error
errMsg = apiError or "Failed to parse trade leagues JSON"
if type(apiError) == "table" then
errMsg = apiError.message or (apiError.code and tostring(apiError.code)) or "Failed to parse trade leagues JSON"
end
return callback({"Standard", "Hardcore"}, errMsg)
end
local leagues = {}
for _, value in pairs(json_data.result) do
Expand Down
Loading