Skip to content

WorldEdit bulk operations can log changes before they occur #967

Description

@Telesphoreo

Description

CoreProtect queues records before WorldEdit applies a bulk set or replace operation. If the operation fails, CoreProtect can retain records for block changes that did not occur.

The bulk methods in CoreProtectLogger also evaluate the pattern once for logging and again for the edit. A stateful or random pattern can therefore produce a log that differs from the applied change.

Expected behavior

CoreProtect should evaluate each pattern once and queue a record only when the extent accepts the block change.

Scope

The problem affects WorldEdit and FastAsyncWorldEdit logging with every database backend.

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions