Repository navigation
Conversation
… correction log Closes #332 Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Contributor
There was a problem hiding this comment.
🟢 Approval recommended
The narrow implementation matches the requested behavior, preserves stored data, and includes focused regression coverage with no identified blocking issues.
0 open findings
What changed in this PR
Adds an opt-in privacy control to DataSure’s replication exports, addressing #332 for the 1.2.0 release.
Changes:
- Blanks reviewer names only in the exported correction log, preserving its schema and stored data.
- Invalidates built packages when export settings change.
- Adds regression tests and user documentation.
| File | Description |
|---|---|
| tests/views/test_replication_view.py | Tests checkbox forwarding and package invalidation. |
| tests/replication/test_package_builder.py | Tests name exclusion, defaults, schema, and stored-log preservation. |
| src/datasure/views/replication_view.py | Adds the checkbox and tracks export settings. |
| src/datasure/replication/package_builder.py | Supports optional reviewer-name blanking during export. |
| docs/USER_GUIDE.md | Explains the privacy option and unchanged defaults. |
| CHANGELOG.md | Records the new export option. |
🧠 Review effort: Balanced
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
|
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.



Pull Request Summary 🚀
What does this PR do? 📝
Adds an Exclude reviewer names option to the Export Replication Package page.
correction_log.csvrecords who made each correction.build_replication_package: a newexclude_reviewer_namesargument. When set, theusercolumn is blanked in the exported4_output/3_logs/correction_log.csvonly.Closes #332
Why is this change needed? 🤔
The
usercolumn is new in 1.2.0 (#322). It holds the sidebar Reviewer name, or the OS login, which is often the person's full name on Windows. Without this option, reviewers' names go into every replication package, including ones shared outside the team. Promoted to a v1.2.0 blocker (#339) because this release is the one that starts exporting names.How was this implemented? 🛠️
_blank_reviewer_namessetsuserto null and keeps the column, so the export still matchesCORRECTION_LOG_SCHEMA. The stored log is never written._replication_page_selto_replication_build_settings.Merge danger: two-way door. Blast radius: narrow, limited to the replication export. The default output is unchanged.
How to test or reproduce ? 🧪
Before: no option;
correction_log.csvalways containeduser.After:
TestExcludeReviewerNamesintests/replication/test_package_builder.py, plus view tests:uservalues are exported.usercolumn is present with all values blank, and other columns are unchanged.just test: 3915 passed, 6 skipped.Manual check: make a correction with a Reviewer name set, build the package with and without the box ticked, and open
4_output/3_logs/correction_log.csv.Screenshots (if applicable) 📷
N/A
Checklist ✅
Reviewer Emoji Legend
:code::smiley::+1::100:...and I want the author to know it! This is a way to highlight positive parts of a code review.
:star: :star: :star:And I am providing reasons why it needs to be addressed as well as suggested improvements.
:star: :star:And I am providing suggestions where it could be improved either in this PR or later.
:star:...and consider this a suggestion, not a requirement.
:question:This should be a fully formed question with sufficient information and context that requires a response.
:memo::pick:This does not require any changes and is often better left unsaid. This may include stylistic, formatting, or organization suggestions and should likely be prevented/enforced by linting if they really matter
:recycle:Should include enough context to be actionable and not be considered a nitpick.
🤖 Generated with Claude Code