Repository navigation
Print for loops with the CompCert guard orientation - #876
Merged
andrew-appel merged 1 commit intoNov 9, 2026
Merged
Conversation
The specialized for-loop notation printed a guard that breaks when true as a continuing condition. Match Sifthenelse guard Sskip Sbreak instead, as CompCert's Swhile and Sfor expand. The opposite orientation still prints as the generic loop containing its conditional break.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
for (; e; step)printing notation matchedSifthenelse e Sbreak Sskip, a loop that stops wheneholds, so it printed such loops with the condition inverted. CompCert'sSwhileandSforexpand toSifthenelse e Sskip Sbreak, which this matches instead. Loops from clightgen now print asfor (; _i < _n; ...)instead of a generic loop withif (! _i < _n) { break; }inside.Tested on Rocq 9.1.1 at both bit sizes:
make vst,make testandmake assumptions.txtpass with unchanged assumptions.