Markup: match comments containing a nested "<!--" - #4103
Open
spokodev wants to merge 1 commit into
Open
Conversation
✅ Deploy Preview for dev-prismjs-com ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Prism's
commentrule for markup uses/<!--(?:(?!<!--)[\s\S])*?-->/, which refuses to match once it encounters a second<!--inside the comment body. Per the HTML tokenizer (WHATWG §13.2.5 comment states), a comment ends at the first-->; an embedded<!--has no special meaning and is just content.So
<!-- foo <!-- bar -->— commented-out markup that itself contains a comment marker — fails to tokenize as a comment and falls through to thetagrule, which mis-highlights the whole thing as a bogus HTML tag. Dropping the(?!<!--)guard matches the comment as a single token, in line with the spec. Added a test case.