Skip to content

fix: make check-links.sh work on bash 3.2#568

Open
mesutoezdil wants to merge 1 commit into
Project-HAMi:masterfrom
mesutoezdil:fix/check-links-bash-compat
Open

fix: make check-links.sh work on bash 3.2#568
mesutoezdil wants to merge 1 commit into
Project-HAMi:masterfrom
mesutoezdil:fix/check-links-bash-compat

Conversation

@mesutoezdil

@mesutoezdil mesutoezdil commented Jul 10, 2026

Copy link
Copy Markdown
Contributor

mapfile needs bash 4+. macOS ships bash 3.2 by default, so npm run check-links fails there with mapfile: command not found. Replaced with a plain read loop.

Signed-off-by: mesutoezdil <mesudozdil@gmail.com>
@hami-robot

hami-robot Bot commented Jul 10, 2026

Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: mesutoezdil
Once this PR has been reviewed and has the lgtm label, please assign windsonsea for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@hami-robot hami-robot Bot requested review from wawa0210 and windsonsea July 10, 2026 20:52
@netlify

netlify Bot commented Jul 10, 2026

Copy link
Copy Markdown

Deploy Preview for project-hami ready!

Name Link
🔨 Latest commit 6af156e
🔍 Latest deploy log https://app.netlify.com/projects/project-hami/deploys/6a515b7a37600a00099231d5
😎 Deploy Preview https://deploy-preview-568--project-hami.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
🤖 Make changes Run an agent on this branch

To edit notification comments on pull requests, go to your Netlify project configuration.

@hami-robot hami-robot Bot added the size/XS label Jul 10, 2026
@coderabbitai

coderabbitai Bot commented Jul 10, 2026

Copy link
Copy Markdown

Review Change Stack

📝 Walkthrough

Walkthrough

The link-check script now loads skip arguments from skip-args.txt with a line-by-line read loop, preserving their subsequent use when invoking linkinator.

Changes

Link checking

Layer / File(s) Summary
Skip-argument loading
scripts/check-links.sh
Replaces mapfile with an IFS= read -r loop that appends each skip argument to skip_args before the linkinator invocation.

Estimated code review effort: 2 (Simple) | ~5 minutes

Poem

I’m a rabbit with links in my lair,
Reading skip lines with careful flair.
One by one they hop in the array,
Then linkinator checks the way.
No broken paths shall hide today!

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title accurately summarizes the main change: making check-links.sh compatible with Bash 3.2.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant