Skip to content

docs(plan): record #102 as closed by #203, and the run that exercised it - #214

Merged
mmcky merged 2 commits into
mainfrom
claude/sharp-euler-oddda6
Sep 28, 2026
Merged

mmcky merged 2 commits into
mainfrom
claude/sharp-euler-oddda6

Conversation

@quantecon-services

@quantecon-services quantecon-services commented Sep 28, 2026 •

Copy link
Copy Markdown
Collaborator

Fixes a stale row in docs/dev/PLAN.md (a loose end listed in #212).

The #102 row in the disposition table still said to review #203 and to validate it with a maintainer dispatch after merge, and it called #144 open. Now:

The row now says that, and its disposition becomes "—", like the other closed rows. The Last updated header gains an entry.

Only PLAN.md changes, so there is no changelog entry, as with #200. generate-docs.py --check passes and the table's cell counts are unchanged.

🤖 Generated with Claude Code

https://claude.ai/code/session_01SUGTRULyyM87pug2MckrXo

The #102 row still said to review #203 and to validate it with a
maintainer dispatch after merge, and called #144 open. #203 merged on
2026-09-28 and closed #102, and #144 was closed unmerged.

The weekly matrix run the same day (36370003884) did the validation
the row asked for. Six of eight legs passed, lecture-python-programming
on both images among them. Both lecture-python.myst legs failed the
retry on bayes_nonconj alone, which is the retry working as intended:
a persistent failure still fails the leg.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01SUGTRULyyM87pug2MckrXo

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot review overview

🟡 Changes recommended

The new row's (#159) reference points to this repo's CI-failure alert issue rather than the lecture-python.myst fix it claims "belongs in that repo," which is an accuracy nit in an accuracy-focused doc.

Review effort: Balanced
Findings: 1 Low severity

Open (1)
What changed in this PR

This PR updates a single stale row (and the running changelog header) in docs/dev/PLAN.md to reflect that issue #102 was closed by PR #203 on 2026-09-28, and that the weekly matrix run the same day validated the retry the row previously asked a maintainer to run. It is one of a series of documentation-accuracy PLAN.md updates (e.g. #200) and carries no code or CHANGELOG changes.

Changes:

  • Rewrites the #102 disposition row from "Body superseded / Review #203 / validate after merge" to "Closed — fixed by #203", records the validating run 36370003884 (6/8 legs passed, lecture-python-programming on both images), notes both lecture-python.myst legs failed persistently on bayes_nonconj, and marks #144 closed-unmerged; disposition becomes "—" like other closed rows.
  • Adds a new "Last updated" header entry noting the #102 row now records #203's closure and the matrix run.
File Description
docs/​dev/​PLAN.md Updates the #102 disposition-table row and the "Last updated" header to record #203 closing #102 and the 2026-09-28 matrix run that exercised the retry.

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

Comment thread docs/dev/PLAN.md Outdated
The row said bayes_nonconj's fix belongs in lecture-python.myst and then
cited #159, which is this repo's CI-failure alert for the red matrix,
not that fix. It now links lecture-python.myst#1065 for the fix and names
#159 as what tracks the red matrix. Raised in Copilot's review.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01SUGTRULyyM87pug2MckrXo
@mmcky
mmcky merged commit 1bfcae6 into main Sep 28, 2026
29 checks passed
@mmcky
mmcky deleted the claude/sharp-euler-oddda6 branch September 28, 2026 11:01
quantecon-services pushed a commit that referenced this pull request Sep 28, 2026
#214 and this branch each put a new first entry on PLAN's "Last updated"
line. Both are kept, this branch's first since it lands last, followed by
#214's and then #211's. #214's #102 row and this branch's item 10 row do
not overlap.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01FeKTxWtkzVMyPbqeSgM2Tb
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

test-containers-lectures: absorb transient raw-GitHub 429s when building lecture repos

4 participants