[organization_capital.md] Update np.random → Generator API - #1014
Open
Chihiro2000GitHub wants to merge 1 commit into
Open
[organization_capital.md] Update np.random → Generator API#1014Chihiro2000GitHub wants to merge 1 commit into
Chihiro2000GitHub wants to merge 1 commit into
Conversation
56 tasks
📖 Netlify Preview Ready!Preview URL: https://pr-1014--sunny-cactus-210e3e.netlify.app Commit: 📚 Changed LecturesBuild Info
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR migrates legacy NumPy random API usage in
organization_capital.mdas part of QuantEcon/meta#299.The lecture already builds a seeded generator in its four simulation functions. This PR brings the one remaining cell, which still used
np.random.seed(...)andnp.random.randn(...), into line with them.Related PRs and issues
I checked for open PRs and issues related to this lecture. No open PR modifies
organization_capital.md, and no open issue concerns this migration.While checking the rebuilt figure I did notice that the posterior-mean panel does not show the convergence the text describes. That is pre-existing, and I have filed it separately as #1015.
Details
np.random.seed(0)→rng = np.random.default_rng(0)andnp.random.randn(T)→rng.standard_normal(T).0) is kept, and no new seed was introduced.rng = np.random.default_rng(seed)calls elsewhere in the lecture are unchanged.@jit,@njit,@jitclass,parallel=True,prange) code.organization_capital.mdexecuted without errors.Note for reviewers
Only the left panel of the posterior figure changes: the posterior standard deviation plotted on the right does not depend on the draws.
Hi @mmcky and @HumphreyYang, I'd be grateful if you could take a look when you have time.