Conversation
The GitHub Actions Pages deploy that publish-gh-pages uses ignores a CNAME file, so the input never set the custom domain: Settings → Pages does, and it already holds python.quantecon.org. From QuantEcon/actions v0.12.0 the action warns on every deploy that still passes it (QuantEcon/actions#109, QuantEcon/actions#110). Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
Contributor
There was a problem hiding this comment.
Copilot review overview
🟢 Approval recommended
The change is a small, valid YAML update that removes an unused action input and adds clarifying documentation without affecting build or deploy logic.
Review effort: Lite
Findings: None
What changed in this PR
This PR updates the GitHub Pages publish workflow to stop passing the deprecated/ineffective cname input to quantecon/actions/publish-gh-pages, and documents where the site’s custom domain is actually configured (GitHub repo Settings → Pages).
Changes:
- Remove the
cname: python.quantecon.orginput from thepublish-gh-pagesaction invocation. - Add an inline comment explaining that the custom domain is managed via Settings → Pages and that a
CNAMEfile is ignored for this deployment path.
| File | Description |
|---|---|
| .github/workflows/publish.yml | Drops the unused cname input and adds documentation clarifying how the custom domain is configured for Pages deployments. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
📖 Netlify Preview Ready!Preview URL: https://pr-1064--sunny-cactus-210e3e.netlify.app Commit: Build Info
|
4 tasks
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
publish-gh-pagesdeploys through GitHub Actions Pages, which ignores aCNAMEfile, so thecname:input has never set the custom domain. Settings → Pages does, and it holdspython.quantecon.org(checked withgh api repos/QuantEcon/lecture-python.myst/pages:cname: python.quantecon.org,build_type: workflow,https_enforced: true). From QuantEcon/actions v0.12.0 the action warns on every deploy that still passes the input. This removes it and leaves a comment saying where the domain lives.No effect on the published site. The only other thing the input did was write a
CNAMEfile into the build directory, so the release HTML archive stops carrying one; nothing reads it when serving.This workflow runs on a
publish*tag, so this PR's CI does not exercise it. The check is the next real publish after merge: the next publish run should show nocnamewarning (this repo is on@v0, so it sees the warning today), and the site should still serve onpython.quantecon.org.Follow-up from QuantEcon/actions#110.
Assisted-by: Claude Code (Claude Opus 5.5)
🤖 Generated with Claude Code