Skip to content

feat(attention): add CP backward drift validation - #284

Open
inaniloquentee wants to merge 13 commits into
testfrom
codex/ws2-pr8-cp-attention-backward
Open

feat(attention): add CP backward drift validation#284
inaniloquentee wants to merge 13 commits into
testfrom
codex/ws2-pr8-cp-attention-backward

Conversation

@inaniloquentee

@inaniloquentee inaniloquentee commented Aug 7, 2026

Copy link
Copy Markdown
Collaborator

Scope

PR8 fixes the strict backward schedule for CP prefill and chunked-prefill.

Contract

Area Enforced behavior
Gradient order Canonical batch, query, and global-KV traversal
Reduction FP32 accumulation with fixed logical merge order
Outputs Covers dQ, dK, and dV, including CP ownership
Split-KV Disabled in strict backward mode

Validation

Check Result
Strict backward suite 57 passed
Integrated 8xH100 backward gate Passed: dQ/dK/dV max abs 0.0 across 2/4/8 ranks

Boundary

This PR owns backward arithmetic order and gradient coverage. PR285 and #294 record the production H100 evidence.

Commit: 9e5c400

@coderabbitai

coderabbitai Bot commented Aug 7, 2026

Copy link
Copy Markdown

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro Plus

Run ID: e8f8be5e-a566-480f-a26e-f8e81339d0de

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@inaniloquentee
inaniloquentee changed the base branch from feat/ws2-cp-attention-reference-pr3 to test August 12, 2026 16:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant