Repository navigation
Conversation
Contributor
There was a problem hiding this comment.
🟡 Changes recommended
The crash fix lacks regression coverage for index-wrapped Numeric values.
1 open finding
What changed in this PR
Fixes index normalization when Numeric wraps an MLIR index value.
Changes:
- Recursively unwraps
Numericvalues so index operands convert toInt64.
| File | Description |
|---|---|
python/flydsl/expr/primitive.py |
Recursively normalizes integer-tuple leaves. |
🧠 Review effort: Balanced
💡 Configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
| if isinstance(value.value, ir.Value) and type(value).width < 32: | ||
| return Int32(value).value | ||
| return value.value | ||
| return _expand_int_tuple_leaves(value.value) |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Fixes #1218
Technical Details
We need to unwrap
Numericrecursively since it can wrapir.IndexType. Adding recursive handle to correctly convertNumeric->IndexType->Int64Test Plan
Add tests to test the failing case and width preservation
Test Result
Submission Checklist