add atimes test for date-idate subtraction#7827
Merged
Merged
Conversation
MichaelChirico
approved these changes
Jul 21, 2026
Generated via commit dde4839 Download link for the artifact containing the test results: ↓ atime-results.zip
|
Member
|
Hmm, I'm not seeing the slowdown here, should I be? |
Member
Author
|
Nah, not in this graph. Maybe I need to increase N, will check |
ben-schwen
force-pushed
the
date_idate_subtraction
branch
from
July 23, 2026 07:47
29cdd79 to
10db18d
Compare
Member
Author
|
Apparently it had something to do with S3 registration. @tdhock and @Anirban166 probably know better about this, but I've tried to explain it in the comment ^^ |
| Before = "84b0e32f7a1bfdd8ec3a2c4012010b3ec072b31f", # Parent of the regression commit. | ||
| Regression = "cfa9f49bd27195962573ad493a31600d173abc5c", # Merge commit of #7213 which added chooseOpsMethod.IDate. | ||
| seconds.limit = 1, | ||
| # Reset the shared base S3 table to match the version under test (see "Caveat" in the intro above). |
Member
There was a problem hiding this comment.
Seems like a possible bug/FR for {atime}? cc @tdhock
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Towards #7825