RC-T40 Chat Fixes

[ucswift]

Summary by CodeRabbit

• New Features

  • Added support for unit-wide dispatch chat channels.
  • Expanded incident channel grouping and updated incident icons.
  • Added shared light and dark theme support across web and native platforms.

• Bug Fixes

  • Improved text alignment and vertical sizing in input and selection fields.
  • Restored incident command updates after hub reconnection.
  • Improved department rejoining and connection-state handling during reconnection.

[coderabbitai]

Warning

Review limit reached

@ucswift, you've reached your PR review limit, so we couldn't start this review.

Next review available in: 7 minutes

You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository.

How can I continue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews.

How do review limits work?

CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability.

For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window.

Please refer docs for additional details.

Review details

⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro Plus

Run ID: 1d105053-f29a-49c0-b456-47a541a1586d

📥 Commits

Reviewing files that changed from the base of the PR and between 5e3b2ff and a09f7ec.

📒 Files selected for processing (7)

• gluestack-ui.config.json
• src/components/ui/gluestack-ui-provider/index.tsx
• src/components/ui/input/index.tsx
• src/components/ui/select/index.tsx
• src/components/ui/text-field-metrics.ts
• src/hooks/use-signalr-lifecycle.ts
• tsconfig.json

📝 Walkthrough

Walkthrough

The changes add platform-specific theme loading, expand chat channel classification, restore incident state after SignalR update-hub reconnection, and apply platform-specific text metrics to native input controls.

Changes

Theme system

Layer / File(s)	Summary
Shared theme tokens theme-tokens.css	Adds shared color, typography, background, shadow, Tailwind, and focus tokens.
Platform theme entry points global.css, global.web.css, src/lib/theme-styles.ts, src/lib/theme-styles.web.ts, src/app/_layout.tsx, src/components/ui/gluestack-ui-provider/index.tsx	Separates native system dark mode from web .dark-class handling and loads the matching stylesheet entry.

Chat channel classification

Layer / File(s)	Summary
Chat channel contract src/models/v4/chat/chatEnums.ts	Adds the UnitDispatch channel type with value 11.
Incident grouping and validation src/components/chat/chat-utils.ts, src/app/(app)/chat.tsx, src/components/chat/__tests__/chat-utils.test.ts	Groups incident lead and incident dispatch channels as incidents. Tests cover incident grouping, unit dispatch grouping, and archived-channel exclusion.

SignalR update-hub recovery

Layer / File(s)	Summary
Update-hub lifecycle handling src/stores/signalr/signalr-store.ts	Adds dedicated lifecycle handlers for reconnect and disconnect events. Reconnection restores department and incident command state.
Lifecycle resume refresh src/hooks/use-signalr-lifecycle.ts	Refreshes incident command state after successful update-hub reconnection when an active call exists.

Native input metrics

Layer / File(s)	Summary
Input and select vertical metrics src/components/ui/input/index.tsx, src/components/ui/select/index.tsx	Adds iOS and Android text metrics and preserves caller-provided styles after platform-specific fixes.

Estimated code review effort: 4 (Complex) | ~60 minutes

Mergeability Score: 🔵 Low · up to 5e3b2

The PR improves chat reconnect and theming behavior, but it can still reload the board after an unsuccessful update-hub reconnect and may trigger Stylelint failures from the new CSS syntax. It is mergeable with explicit owner awareness or follow-up on these bounded issues.

Sequence Diagram(s)

sequenceDiagram
  participant UpdateHub
  participant SignalRStore
  participant IncidentCommandStore
  UpdateHub->>SignalRStore: Emit reconnect event
  SignalRStore->>SignalRStore: Reconnect department
  SignalRStore->>IncidentCommandStore: Refresh open incident command
  UpdateHub->>SignalRStore: Emit disconnect event
  SignalRStore->>SignalRStore: Remove lifecycle handlers

Loading

Possibly related PRs

• Resgrid/Dispatch#75: Shares the .web-input-accessible focus styling moved into theme-tokens.css.
• Resgrid/Dispatch#80: Provides related web color-scheme and NativeWind theme infrastructure.
• Resgrid/Dispatch#122: Introduces the chat channel types and grouping logic extended here.

Suggested reviewers: github-actions

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name	Status	Explanation	Resolution
Docstring Coverage	⚠️ Warning	Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%.	Write docstrings for the functions missing them to satisfy the coverage threshold.

✅ Passed checks (4 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The title identifies real chat-related changes but does not describe the broader theme, lifecycle, and input fixes in the changeset.
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.

✨ Finishing Touches 💡 2

📝 Generate docstrings 💡

• Create stacked PR
• Commit on current branch

🛠️ Fix failing CI checks 💡

• Create stacked PR
• Commit on current branch

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Commit unit tests in branch develop

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands.}

[coderabbitai]

Actionable comments posted: 2

🧹 Nitpick comments (1)

theme-tokens.css (1)

675-676: 📐 Maintainability & Code Quality | 🔵 Trivial | ⚡ Quick win

Stylelint does not recognize the Tailwind v4 at-rules used by the new theme files. The root cause is one configuration gap: scss/at-rule-no-unknown has no ignoreAtRules entries for Tailwind v4, and value-keyword-case treats the font family name as a keyword. Fix the stylelint configuration once; do not change the CSS.

• theme-tokens.css#L675-L676: keep @theme and Roboto; add theme to ignoreAtRules and Roboto to ignoreKeywords.
• theme-tokens.css#L543-L543: keep @theme inline; covered by the same ignoreAtRules entry.
• global.css#L17-L17: keep @custom-variant; add custom-variant to ignoreAtRules.
• global.web.css#L12-L12: keep @custom-variant; covered by the same ignoreAtRules entry.

🤖 Prompt for AI Agents

Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

In `@theme-tokens.css` around lines 675 - 676, Update the Stylelint configuration,
not the CSS: add theme and custom-variant to scss/at-rule-no-unknown’s
ignoreAtRules, and add Roboto to value-keyword-case’s ignoreKeywords. This
covers theme-tokens.css lines 675-676 and 543-543, global.css line 17, and
global.web.css line 12; make no direct changes at those sites.

Source: Linters/SAST tools

🤖 Prompt for all review comments with AI agents

Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Inline comments:
In `@src/hooks/use-signalr-lifecycle.ts`:
- Around line 140-149: Update connectUpdateHub and the reconnect handling in
use-signalr-lifecycle so connectUpdateHub returns or propagates an explicit
success/failure result instead of resolving after setup errors. Gate
handleIncidentCommandUpdated in the openCallId block on that successful
update-hub connection result, rather than only checking results[0].status ===
'fulfilled'.

In `@theme-tokens.css`:
- Around line 146-539: Remove the duplicated light and dark token declarations
between :root, :root.light, and the prefers-color-scheme dark block. Keep one
canonical definition for each theme and generate or reuse it for both the
media-query and explicit theme selectors, preserving all existing token values
and selector behavior.

---

Nitpick comments:
In `@theme-tokens.css`:
- Around line 675-676: Update the Stylelint configuration, not the CSS: add
theme and custom-variant to scss/at-rule-no-unknown’s ignoreAtRules, and add
Roboto to value-keyword-case’s ignoreKeywords. This covers theme-tokens.css
lines 675-676 and 543-543, global.css line 17, and global.web.css line 12; make
no direct changes at those sites.

🪄 Autofix

Fix all unresolved CodeRabbit comments on this PR:

• Push a commit to this branch (recommended)
• Create a new PR with the fixes

---

ℹ️ Review info

⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro Plus

Run ID: e29b0187-62d1-4d82-bc04-a599a970dfa3

📥 Commits

Reviewing files that changed from the base of the PR and between 0d813e6 and 5e3b2ff.

📒 Files selected for processing (15)

• global.css
• global.web.css
• src/app/(app)/chat.tsx
• src/app/_layout.tsx
• src/components/chat/__tests__/chat-utils.test.ts
• src/components/chat/chat-utils.ts
• src/components/ui/gluestack-ui-provider/index.tsx
• src/components/ui/input/index.tsx
• src/components/ui/select/index.tsx
• src/hooks/use-signalr-lifecycle.ts
• src/lib/theme-styles.ts
• src/lib/theme-styles.web.ts
• src/models/v4/chat/chatEnums.ts
• src/stores/signalr/signalr-store.ts
• theme-tokens.css

[coderabbitai]

🎯 Functional Correctness | 🟡 Minor | ⚡ Quick win

🧩 Analysis chain

🏁 Script executed:

#!/bin/bash
# Find where the web dark/light class is applied to <html> and whether it runs before paint.
rg -n --iglob '*.{ts,tsx,js,jsx,html}' -C4 'classList|documentElement|applyColorScheme'
fd -i -e html . | xargs -r rg -n -C3 'dark|colorScheme'

Repository: Resgrid/Dispatch

Length of output: 154

---

🏁 Script executed:

#!/bin/bash
set -u

printf '%s\n' '--- candidate files ---'
git ls-files | rg '(^|/)(theme-tokens\.css|global(\.web)?\.css|use-selected-theme\.web\.tsx|.*html$|.*web.*\.(ts|tsx|js|jsx)$)$' || true

printf '%s\n' '--- theme and web entry references ---'
rg -n -C3 --glob '*.css' --glob '*.{ts,tsx,js,jsx,html}' \
  'theme-tokens|use-selected-theme|classList|documentElement|localStorage|prefers-color-scheme|dark:|colorScheme' . || true

Repository: Resgrid/Dispatch

Length of output: 50373

---

🏁 Script executed:

#!/bin/bash
set -u

log=/tmp/coderabbit-shell-logs/shell-output-K6f5ZU

printf '%s\n' '--- exact candidate paths from the captured search ---'
rg -n '(^|/)(theme-tokens\.css|global(\.web)?\.css|use-selected-theme\.web\.tsx|[^/]+\.html)(:|$)' "$log" | head -n 120 || true

printf '%s\n' '--- focused class and theme references ---'
rg -n -C5 --glob '!src/app/**' --glob '!src/components/**' \
  'classList|documentElement|applyColorScheme|use-selected-theme|prefers-color-scheme|localStorage' . \
  | head -n 300 || true

printf '%s\n' '--- HTML files and relevant contents ---'
git ls-files | rg '\.html$' | while IFS= read -r file; do
  printf '\n--- %s ---\n' "$file"
  rg -n -C5 'dark|light|theme|colorScheme|script' "$file" || true
done

Repository: Resgrid/Dispatch

Length of output: 50373

---

🏁 Script executed:

#!/bin/bash
set -u

printf '%s\n' '--- tracked files with relevant names ---'
git ls-files | grep -E '(^|/)(theme-tokens\.css|global(\.web)?\.css|use-selected-theme(\.web)?\.tsx|[^/]+\.html)$' || true

printf '%s\n' '--- tracked source references, excluding generated and embedded sources ---'
git ls-files '*.ts' '*.tsx' '*.js' '*.jsx' '*.css' '*.html' \
  | grep -Ev '(^|/)(node_modules|dist|build|webview-scripts\.ts)/|\.map$' \
  | xargs -r rg -n -C3 \
    'classList|documentElement|applyColorScheme|use-selected-theme|prefers-color-scheme|localStorage|theme-tokens|global\.web\.css|global\.css' \
  | head -n 500

Repository: Resgrid/Dispatch

Length of output: 50373

---

🏁 Script executed:

#!/bin/bash
set -u

printf '%s\n' '--- relevant tracked paths ---'
git ls-files | grep -E '(^|/)(theme-tokens\.css|global(\.web)?\.css|use-selected-theme(\.web)?\.tsx|_layout\.tsx|\+html\.tsx|index\.web\.tsx)$' || true

for file in global.css global.web.css src/app/_layout.tsx src/app/+html.tsx src/components/ui/gluestack-ui-provider/index.tsx src/components/ui/gluestack-ui-provider/index.web.tsx src/lib/hooks/use-selected-theme.web.tsx src/lib/hooks/use-selected-theme.ts; do
  if [ -f "$file" ]; then
    printf '\n--- %s ---\n' "$file"
    cat -n "$file" | sed -n '1,180p'
  fi
done

printf '\n--- theme token locations ---\n'
git ls-files | grep 'theme-tokens\.css$' | while IFS= read -r file; do
  printf '%s\n' "$file"
  wc -l "$file"
done

Repository: Resgrid/Dispatch

Length of output: 19102

---

🏁 Script executed:

#!/bin/bash
set -u

for file in src/components/ui/gluestack-ui-provider/script.ts src/components/ui/gluestack-ui-provider/script.tsx src/app/_layout.tsx src/app/'(app)'/_layout.tsx; do
  if [ -f "$file" ]; then
    printf '\n--- %s ---\n' "$file"
    cat -n "$file" | sed -n '1,260p'
  fi
done

printf '\n--- provider and selected-theme call sites ---\n'
git ls-files '*.ts' '*.tsx' \
  | grep -Ev '(^|/)(node_modules|dist|build)/|webview-scripts\.ts|form-render-source\.ts' \
  | xargs -r rg -n -C4 'GluestackUIProvider|useSelectedTheme|loadSelectedTheme|selectedTheme'

Repository: Resgrid/Dispatch

Length of output: 41153

---

🏁 Script executed:

#!/bin/bash
python3 - <<'PY'
from pathlib import Path
import re

text = Path("theme-tokens.css").read_text()

def block_after(marker):
    start = text.index(marker)
    brace = text.index("{", start)
    depth = 0
    for i in range(brace, len(text)):
        if text[i] == "{":
            depth += 1
        elif text[i] == "}":
            depth -= 1
            if depth == 0:
                return text[brace + 1:i]
    raise ValueError(marker)

def declarations(block):
    return dict(re.findall(r"(--color-[\w-]+)\s*:\s*([^;]+);", block))

light_root = declarations(block_after(":root {"))
dark_media = declarations(block_after("`@media` (prefers-color-scheme: dark)"))
dark_class = declarations(block_after(":root.dark"))
light_class = declarations(block_after(":root.light"))

for name, values in [
    ("light :root vs :root.light", (light_root, light_class)),
    ("dark media vs :root.dark", (dark_media, dark_class)),
]:
    left, right = values
    missing = sorted(set(left) ^ set(right))
    changed = sorted(k for k in set(left) & set(right) if left[k] != right[k])
    print(name)
    print("  token counts:", len(left), len(right))
    print("  missing:", missing)
    print("  changed:", changed)
PY

Repository: Resgrid/Dispatch

Length of output: 3311

---

🏁 Script executed:

#!/bin/bash
python3 - <<'PY'
from pathlib import Path
import re

text = Path("theme-tokens.css").read_text()

def css_block(selector, occurrence=0):
    positions = [m.start() for m in re.finditer(re.escape(selector), text)]
    start = positions[occurrence]
    brace = text.index("{", start)
    depth = 0
    for i in range(brace, len(text)):
        if text[i] == "{":
            depth += 1
        elif text[i] == "}":
            depth -= 1
            if depth == 0:
                return text[brace + 1:i]
    raise ValueError(selector)

def declarations(block):
    return dict(re.findall(r"(--color-[\w-]+)\s*:\s*([^;]+);", block))

root = declarations(css_block(":root {", 0))
media = declarations(css_block("`@media` (prefers-color-scheme: dark)", 0))
dark = declarations(css_block(":root.dark", 0))
light = declarations(css_block(":root.light", 0))

print("root sample:", root.get("--color-primary-0"), root.get("--color-background-0"))
print("media sample:", media.get("--color-primary-0"), media.get("--color-background-0"))
print("dark sample:", dark.get("--color-primary-0"), dark.get("--color-background-0"))
print("light sample:", light.get("--color-primary-0"), light.get("--color-background-0"))

for name, left, right in [
    ("light :root vs :root.light", root, light),
    ("dark media vs :root.dark", media, dark),
]:
    changed = [(k, left[k], right[k]) for k in sorted(set(left) & set(right)) if left[k] != right[k]]
    print(name, "counts:", len(left), len(right), "changed:", len(changed))
    for item in changed[:8]:
        print(" ", item)
PY

Repository: Resgrid/Dispatch

Length of output: 863

---

🏁 Script executed:

#!/bin/bash
set -u

printf '%s\n' '--- selector occurrences ---'
rg -n -F ':root.dark' theme-tokens.css
rg -n -F ':root.light' theme-tokens.css
rg -n -F '`@media` (prefers-color-scheme: dark)' theme-tokens.css

printf '%s\n' '--- relevant token blocks ---'
sed -n '1,35p' theme-tokens.css
sed -n '140,155p' theme-tokens.css
sed -n '270,290p' theme-tokens.css
sed -n '400,420p' theme-tokens.css

Repository: Resgrid/Dispatch

Length of output: 3927

---

Avoid duplicating theme tokens

The light tokens are duplicated in :root and :root.light. The dark tokens are duplicated in the media query and :root.dark. Maintain one canonical token source and generate both selector blocks to prevent drift.

🤖 Prompt for AI Agents

Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

In `@theme-tokens.css` around lines 146 - 539, Remove the duplicated light and
dark token declarations between :root, :root.light, and the prefers-color-scheme
dark block. Keep one canonical definition for each theme and generate or reuse
it for both the media-query and explicit theme selectors, preserving all
existing token values and selector behavior.

Source: Linters/SAST tools

[ucswift]

Approve

[github-actions]

This PR is approved.