Repository navigation
fix: correct autocomplete session tokens - #3
Closed
Ayush Neekhar (ayushneekhar) wants to merge 1 commit into
Closed
Ayush Neekhar (ayushneekhar) wants to merge 1 commit into
Ayush Neekhar (ayushneekhar) wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
resetAutocompleteSession()for searches dismissed without a selection.Why
The native bridges created a fresh token for every prediction and omitted it from Place Details. Google therefore treated prediction requests as autocomplete sessions without Place Details and billed them separately instead of associating them with the selected place.
Google's guidance requires one token for the complete interaction and the same token on the terminating Place Details request:
Validation
git diff --checknode --check index.jsnpm pack --dry-run --cache /private/tmp/codex-react-native-google-places-npm-cacheThis repository has no automated native test harness. Consumers will need a newly published package version before removing any temporary local patch.