Skip to content

Prefer scaledToFit over a constant-content-mode aspectRatio #21

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
RISCfuture merged 1 commit into from
Sep 3, 2026
Merged

Prefer scaledToFit over a constant-content-mode aspectRatio #21

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion SF50 TOLD/Views/Loading/LoadingConsentView.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@ struct LoadingConsentView: View {
VStack(alignment: .center, spacing: 20) {
Image("Logo")
.resizable()
.aspectRatio(contentMode: .fit)
.scaledToFit()
.frame(maxWidth: 200, alignment: .center)
.accessibilityHidden(true)

Expand Down
2 changes: 1 addition & 1 deletion SF50 TOLD/Views/Loading/LoadingProgressView.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -40,7 +40,7 @@ struct LoadingProgressView: View {
VStack {
Image("Logo")
.resizable()
.aspectRatio(contentMode: .fit)
.scaledToFit()
.frame(maxWidth: 200, alignment: .center)
.accessibilityHidden(true)
Text("Loading latest airport information…")
Expand Down
2 changes: 1 addition & 1 deletion SF50 TOLD/Views/Overlays/ErrorSheet.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@ struct ErrorSheet: View {
HStack(alignment: .top) {
Image(systemName: "xmark.octagon")
.resizable()
.aspectRatio(contentMode: .fit)
.scaledToFit()
.frame(maxHeight: 40)
.accessibilityHidden(true)
VStack(alignment: .leading, spacing: 20) {
Expand Down
2 changes: 1 addition & 1 deletion SF50 TOLD/Views/Pickers/AirportPicker/Location/LocationErrorView.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@ struct LocationErrorView: View {
HStack(alignment: .top) {
Image(systemName: "xmark.octagon")
.resizable()
.aspectRatio(contentMode: .fit)
.scaledToFit()
.frame(maxHeight: 40)
.accessibilityHidden(true)
VStack(alignment: .leading, spacing: 20) {
Expand Down
2 changes: 1 addition & 1 deletion SF50 TOLD/Views/WelcomeView.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,7 +29,7 @@ struct WelcomeView: View {
VStack {
Image("Logo")
.resizable()
.aspectRatio(contentMode: .fit)
.scaledToFit()
.frame(maxWidth: 200, alignment: .center)
.accessibilityHidden(true)
Text("Welcome to SF50 TOLD")
Expand Down
Loading