Skip to content

Improved gradient information for Symmetric kernel - #1002

Closed
mirjanic wants to merge 1 commit into
SheffieldML:develfrom
mirjanic:devel
Closed

mirjanic wants to merge 1 commit into
SheffieldML:develfrom
mirjanic:devel

Conversation

@mirjanic

Copy link
Copy Markdown

This pull request adds a fix for the gradient information of the Symmetric kernel by implementing gradients_X_diag. Any feedback is appreciated!

@codecov

codecov Bot commented Jan 17, 2023

Copy link
Copy Markdown

Codecov Report

Merging #1002 (db439d7) into devel (f63ed48) will decrease coverage by 0.00%.
The diff coverage is 33.33%.

Additional details and impacted files
@@            Coverage Diff             @@
##            devel    #1002      +/-   ##
==========================================
- Coverage   54.49%   54.49%   -0.01%     
==========================================
  Files         210      210              
  Lines       21560    21563       +3     
  Branches     3169     3169              
==========================================
+ Hits        11750    11751       +1     
- Misses       9255     9257       +2     
  Partials      555      555              

@lawrennd

lawrennd commented Oct 8, 2026 •

Copy link
Copy Markdown
Member

Thank you for this, @mirjanic.

Under CIP-0004 the Symmetric gradients_X_diag improvement still looks like a small mergeable fix, and it is orthogonal to the recent string-identity work in #1126. We would like to land it after rebase + green CI on current devel.

If you can rebase, great; otherwise maintainers can re-implement from your branch and credit you. A short preference note is enough ... but appreciate it's been a long time and if I don't hear, I'll re-implement from your branch!

@lawrennd

Copy link
Copy Markdown
Member

Thank you @mirjanic — under CIP-0004 we tracked this as a kernel quick win.

We are not merging this branch as-is: gradients_X_diag ended up at module scope (not a class method), and the scaled-Kdiag formula omits the cross-term gradients implied by Kdiag. The VibeSafe backlog item and corrected implementation are in #1155; we will close this as superseded when that lands, with credit to you for identifying the missing API.

lawrennd added a commit that referenced this pull request Oct 10, 2026
…s-x-diag

Symmetric.gradients_X_diag + CIP-0004 kernel backlogs (#1002 / #978)
lawrennd added a commit that referenced this pull request Oct 10, 2026
Clean re-implement under CIP-0004: all Periodic subclasses, full saved fields,
rank on Coregionalize, and round-trip tests. Also mark #1002 backlog Completed.
lawrennd added a commit that referenced this pull request Oct 10, 2026
Update CIP-0004 dispositions for the landed quick wins (#938, #1002→#1155, #976→#1156).
lawrennd added a commit to Duncan10/GPy that referenced this pull request Oct 10, 2026
Document SheffieldML#978 (merged) under VibeSafe; re-implement SheffieldML#1002 with a Kdiag-consistent
gradients_X_diag (contributor branch had module-level indent and omitted cross terms).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants