Use a minimum Ruby 3.3 for Dependabot - #1525
Merged
Merged
Conversation
Otherwise it can't upgrade rubocop-shopify or selenium-webdriver, both of which require Ruby 3.3.
etiennebarrie
changed the title
that-jill
approved these changes
Jul 30, 2026
adrianna-chang-shopify
approved these changes
Aug 10, 2026
etiennebarrie
force-pushed
the
use-a-minimum-ruby-3-3-for-dependabot
branch
2 times, most recently
from
August 11, 2026 12:13
639b74d to
d76d628
Compare
This allows Dependabot to take care of Gemfile/Gemfile.lock while not preventing us from testing and supporting 3.2.
etiennebarrie
force-pushed
the
use-a-minimum-ruby-3-3-for-dependabot
branch
from
August 11, 2026 12:16
d76d628 to
714eca7
Compare
Member
Author
|
Actually rewrote the last commit to only use the Rails 8.1-specific Gemfile for Ruby 3.2. That lets us still test 3.3, 3.4 and 4.0 with the exact versions from Gemfile.lock. |
Member
Author
|
That didn't fix the issue 😢 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Otherwise Dependabot can't upgrade rubocop-shopify or selenium-webdriver, both of which require Ruby 3.3.
Also commit changes to Gemfile.lock which happen by just running
bundle install, theBUNDLED WITHsection declaring Bundler 4.0.11 but theCHECKSUMSsection using 4.0.13.Then that broke because we test using Gemfile and Ruby 3.2, which was breaking because of the changed requirement in Gemfile. So moving to test Rails 8.1 with a separate Gemfile, which goes into the other branch and doesn't add the 3.3 Ruby requirement.
That means that CI will no longer have a single case testing precisely with the dependencies declared in Gemfile.lock, but that is mitigated by the weekly CI helping us catch incompatibilities early. We could also add a Ruby 4.0 / Gemfile / sqlite special case to the matrix, which will ensure at least one job passes in the situation where a gem update breaks something in the engine/tests. Not sure how helpful it is, but let me know if you'd want that.