Repository navigation
feat(badge)!: rework component with variant and color props - #388
Merged
Merged
Conversation
H4ad
force-pushed
the
feat/rework-badge-component
branch
from
September 10, 2026 17:36
d115c4f to
019787f
Compare
H4ad
marked this pull request as ready for review
September 10, 2026 18:08
H4ad
force-pushed
the
feat/rework-badge-component
branch
2 times, most recently
from
September 11, 2026 18:03
8d89d21 to
1e3efb4
Compare
H4ad
force-pushed
the
feat/rework-badge-component
branch
from
September 14, 2026 04:12
1e3efb4 to
16a8d88
Compare
H4ad
force-pushed
the
feat/rework-badge-component
branch
from
September 15, 2026 12:53
16a8d88 to
61890b2
Compare
H4ad
force-pushed
the
feat/rework-badge-component
branch
from
September 15, 2026 21:05
61890b2 to
a39f162
Compare
H4ad
force-pushed
the
feat/rework-badge-component
branch
from
September 16, 2026 17:41
a39f162 to
5cdc87b
Compare
H4ad
force-pushed
the
feat/rework-badge-component
branch
2 times, most recently
from
September 22, 2026 21:12
7423ee1 to
e8ccc68
Compare
H4ad
force-pushed
the
feat/rework-badge-component
branch
from
September 24, 2026 14:53
e8ccc68 to
bc047c1
Compare
H4ad
force-pushed
the
feat/rework-badge-component
branch
from
September 24, 2026 19:44
bc047c1 to
4f67326
Compare
YounixM
approved these changes
Sep 25, 2026
H4ad
force-pushed
the
feat/rework-badge-component
branch
from
September 25, 2026 15:40
4f67326 to
a458dec
Compare
H4ad
force-pushed
the
feat/rework-badge-component
branch
from
September 25, 2026 17:45
a458dec to
487a8e8
Compare
YounixM
force-pushed
the
feat/rework-badge-component
branch
from
September 28, 2026 14:19
487a8e8 to
b57a444
Compare
YounixM
force-pushed
the
feat/rework-badge-component
branch
5 times, most recently
from
September 28, 2026 14:40
b85bf2c to
80ec8df
Compare
YounixM
force-pushed
the
feat/rework-badge-component
branch
from
September 28, 2026 14:41
80ec8df to
6839895
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
This reworks the Badge to follow the guidelines of https://github.com/SigNoz/engineering-pod/issues/5984
Closes https://github.com/SigNoz/engineering-pod/issues/6050
Component checklist
Philosophy (guidelines)
Structure (guidelines)
packages/ui/src/, matches the export subpathindex.tsonly re-exports (+ generated token region);export type *plus explicit named exports.jsextension; types imported withimport typesubcomponents/, opinionated compositions inpresets/src/index.ts,vite.config.ts,package.jsonexports,README.md+intro.mdxexternalPatternsCSS (guidelines)
{name}.module.scss, no Tailwind, no CVA, no Sass variablesvar(--{component}-x, <design token>); no hardcoded valuesvar(--spacing-4, 8px)); a bare literal only where no token matches--bg-*/--text-*primitives referenced from a component--{component}-internal-*--x: var(--x)and no duplicated variable definitionsdata-*attributes;data-slotanddata-testidon the rootcolor-mix()for derived shades, neverrgba()over a token:hover,:focus-visible,aria-invalid, disabled all styled@media (prefers-reduced-motion: reduce)pnpm run tokensrun and theindex.tsregion committedVisual QA (guidelines)
parameters.designsmmatchesButton/Input)Typographyor the type-scale tokens, not an ad-hocfont-size/font-weight@signozhq/icons, sized with tokens, no inline SVG with hardcodedpxTypes (guidelines)
{Component}Propsexported; only the props the component actually needs are exposedOriginalProps['x']), never restated by handindex.tsforwardRef+displayName;asChild,testIdsupportedDocs (guidelines)
@defaultwhere applicabletitlegroupargTypescomplete withcategory,type.summary,defaultValue.summary{component}.mdxwith a usage snippet and a<Controls>per exported pieceTests (guidelines)
forward-reftestrun-visual-testinglabel added if the change is visual