feat(tabs)!: rework component on a single items API - #399
Merged
Merged
Conversation
H4ad
added this pull request to stack #386
September 17, 2026 21:18
H4ad
marked this pull request as ready for review
September 17, 2026 21:19
H4ad
force-pushed
the
feat/rework-tabs-component
branch
2 times, most recently
from
September 24, 2026 14:53
b268b31 to
488aeee
Compare
H4ad
force-pushed
the
feat/rework-tabs-component
branch
from
September 24, 2026 19:44
488aeee to
e43c3ea
Compare
YounixM
approved these changes
Sep 25, 2026
H4ad
force-pushed
the
feat/rework-tabs-component
branch
2 times, most recently
from
September 25, 2026 17:45
50648cf to
d10c45a
Compare
YounixM
force-pushed
the
feat/rework-tabs-component
branch
11 times, most recently
from
September 28, 2026 15:07
3a4af16 to
d330faf
Compare
YounixM
force-pushed
the
feat/rework-tabs-component
branch
from
September 28, 2026 15:13
d330faf to
d2ddd5f
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
This re-implements the tabs component on a single
itemsAPI, following the spec defined at https://github.com/SigNoz/engineering-pod/issues/5991On top of the API rework:
utils.ts, and the tabs are held to the React compiler strict check.--tabs-trigger-label-max-width, and the primary trigger is centred and rounded.tabs.module.scss, so every overridable value resolves to a token.Why
The tabs component predates the current guidelines: it exposed a compound API, left its layout values hardcoded, and had no vertical or overflow story.
How to verify
Storybook:
Components/Tabs, plus theTabs Root,Tabs List,Tabs TriggerandTabs Contentstory files.Component checklist
Philosophy (guidelines)
Structure (guidelines)
packages/ui/src/, matches the export subpathindex.tsonly re-exports (+ generated token region);export type *plus explicit named exports.jsextension; types imported withimport typesubcomponents/, opinionated compositions inpresets/src/index.ts,vite.config.ts,package.jsonexports,README.md+intro.mdxexternalPatternsCSS (guidelines)
{name}.module.scss, no Tailwind, no CVA, no Sass variablesvar(--{component}-x, <design token>); no hardcoded valuesvar(--spacing-4, 8px)); a bare literal only where no token matches--bg-*/--text-*primitives referenced from a component--{component}-internal-*--x: var(--x)and no duplicated variable definitionsdata-*attributes;data-slotanddata-testidon the rootcolor-mix()for derived shades, neverrgba()over a token:hover,:focus-visible,aria-invalid, disabled all styled@media (prefers-reduced-motion: reduce)pnpm run tokensrun and theindex.tsregion committedVisual QA (guidelines)
parameters.designsmmatchesButton/Input)Typographyor the type-scale tokens, not an ad-hocfont-size/font-weight@signozhq/icons, sized with tokens, no inline SVG with hardcodedpxTypes (guidelines)
{Component}Propsexported; only the props the component actually needs are exposedOriginalProps['x']), never restated by handindex.tsforwardRefwith a named render function (ordisplayName);testIdsupportedDocs (guidelines)
@defaultwhere applicable@access privateones exempt), correcttitlegroupargTypescomplete withcategory,type.summary,defaultValue.summary{component}.mdxwith a usage snippet and a<Controls>per exported pieceTests (guidelines)
forward-reftestrun-visual-testinglabel added if the change is visual