[3.0] code tag changes - #8891
Closed
live627 wants to merge 1 commit into
Closed
Conversation
live627
commented
Aug 27, 2025
live627
commented
Contributor
- wrap code in preformatted html tags
- do the same in the sceditor
- bonus: fix php tag processing in the sceditor
- add buttons for selecting and expanding code blocks with js; don't output them from php
- remove smfSelectText( ) as it is unused now
- wrap code in preformatted html tags - do the same in the sceditor - bonus: fix php tag processing in the sceditor - do not add php start and end php tags to the final output of the php bbcode - add buttons for selecting and expanding code blocks with js; don't output them from php - remove smfSelectText( ) as it is unused now Signed-off-by: John Rayes <live627@gmail.com>
|
For semantics and accessibility, what about replacing the div header with figure/figcaption? <figure>
<figcaption>PHP code: <button>Select</button> <button>Expand></button></figcaption>
<pre><code>$foo</code></pre>
</figure> |
Member
|
@live627 This is in draft. Is that intended? |
This was referenced Aug 1, 2026
Closed
albertlast
added a commit
to albertlast/SMF2.1
that referenced
this pull request
Aug 1, 2026
…and build their buttons in JS The code BBCode wrapped its content in a bare <code class="bbc_code">, and emitted the "Select" and "Expand" links from PHP even when JavaScript was unavailable to make them work. Tabs and leading/trailing line breaks had to be fixed up by hand, in both the parser and the editor. Wrap the content in a <pre> instead, so the browser preserves the whitespace, and pass the button labels along as data attributes. script.js now builds the buttons from those attributes, which means they only appear when they can actually do something, and the "Expand" button only appears when the block is taller than its maximum height. Migrates every consumer of the old markup: the error log, the SSI examples page, and the profile export. smfSelectText() has no callers left, so it goes; UpgradeTemplate.php probes for attachBbCodeEvents() instead to detect whether script.js loaded. Wave 1, part 1 of breaking up SimpleMachines#7933. Supersedes SimpleMachines#8891. Co-Authored-By: John Rayes <live627@gmail.com> Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
Contributor
Author
|
Superseded by #9332 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.