Conversation
Issues FoundNo issues with your PR description were found. Next Steps
Thank you for your contribution! If you need any help, please reach out on our Discord server. ❤️ |
Testing reportBuilt from source at the PR pin Environment: Steam Deck OLED, SteamOS 3.8.16 Stable, Decky Loader v3.2.8. Built on-device with node 22.23.0 and pnpm 9.15.9. Install, typecheck, 163 tests and build all clean, and the bundle hashed identical to my desktop build. Installed root owned, loader logged What I exercised: the store page panel on a few games, the settings panel in the QAM, and the data path itself from the Deck: credentials endpoint, ITAD lookup, live prices across stores, and the currency API. All returned what the plugin expects. Pulled the panel out of the DOM on Baldur's Gate 3 to be sure: it sits inside One innerHTML write skips the escaping
The ITAD key rides along in the debug object
Settings writes aren't atomic
I saw the quiet half of this on my Deck. After first load Smaller notes
It loads as a legacy plugin and the console warns
Happy to re-test once you push fixes. |
|
This pull request is stale as no updates or testing reports have been posted within the last 7 days. Please ensure you are actively recruiting testers or resolving the issues discussed. If you do not remove the stale label or comment, this will be closed in 7 days. Please close this pull request if you need more time to resolve issues so we can keep our repo healthy. |
|
Not stale still waiting for review |
|
@steam3d Hey, could you share the logs please? I think it's in ~/homebrew/logs/DeckySales/ or Decky->Settings-> Developer->logs. There should be a traceback for me to read. Also is your wishlist private or public? |
|
I reproduced this on my Deck (Decky 3.2.8 Stable). My earlier test done using v1.2.2 ( The Python backend crashes on start, so every call from the UI fails:
The fix I tested on the my deck: move Small one: an empty wishlist returns |
|
@datbird, thank you so much for debugging. I think I genuinely got lucky with the first release working, and the newer release was just an oversight. Fixed the issue, and it should now work. Also added a URL link similar to how you have it on your repo: |
abc7651 to
a105388
Compare
Retest of v1.2.4 (bab0891) The crash is fixed. I built from the pin on my Deck (SteamOS 3.8.16 Stable, Decky 3.2.8). Install, typecheck, 179 tests and build are clean, and the 17 Python tests pass. The loader logs Loaded DeckySales (v1.2.4), settings calls answer in about 1 ms, and View Deals List opens right away instead of spinning. One thing I got wrong yesterday, and it matters now. I said an empty wishlist returns {"response":{}}. It does, but a private one returns the exact same thing, with a 200. I checked a private profile and a friends only profile, and both came back 200 with {"response":{}}. So the new 401/403 check never fires. My own account shows the problem. My wishlist has 632 games, but the public API returns {"response":{}} for it. My profile is public, so it comes down to the Game details privacy setting. Check Now now says "No new deals right now", which looks like a clean run when it actually saw zero games. Before, it at least said private. Sorry for steering you there. Two ways out:
Small one: an empty result returns before WISHLIST_LAST_CHECK is saved, so the panel still says "Not checked yet" after a check. |
|
@datbird sorry pinned the wrong branch. Let me get home today and I'll fix |
|
@datbird fixed! Went on a rabbit hole with the change you suggested but was able to find and test once more. |
|
Retested v1.2.5 (88e92d1) on my Deck, SteamOS Stable. Works now!
|
DeckySales shows the cheapest price live across ~30 stores on any Steam store page, and notifies when a wishlisted game goes on sale at any store, not just Steam. Forked from Deckdeals by ebdevag. Pinned to v1.2.5 (88e92d1), retested on hardware by datbird.
54d3701 to
e4c5ef4
Compare





Add DeckySales to Plugin Store
DeckySales shows you where a game is cheapest anywhere, not just on Steam! It sends you notifications if a game is on sale and shows you the cheapest game available. I built this off of Deckdeals, but it has been disbanded. I've already credited the user as well.
A picture is worth a 1000 words, so here are some images of what I have built.


It adds a panel with Steam's current price next to the lowest price across 30 stores. Prices are also converted between currencies. Wishlist alerts run in the background, and tapping on the notification opens a list of game deals found.
It differs from IsThereAnyDeal for Deck by adding background wishlist alerts across every store, a deals list, a direct "cheapest right now vs Steam" comparison, sale prediction, and currency conversion. I use the IsThereAnyDeal API to pull the latest prices. Just to forewarn, this is a fork of Deckdeals, which was never on the store.
Task Checklist
Developer
Plugin
Backend
Community
Testing