Repository navigation
msm: report the current GPU clock and the temperature - #527
Open
fromdisposition wants to merge 2 commits into
Open
fromdisposition wants to merge 2 commits into
fromdisposition wants to merge 2 commits into
Conversation
The driver has no query for either. Read the clock from the GPU's devfreq, the one whose compatible lists the generic "qcom,adreno", so the GMU is skipped, and the temperature from the hottest thermal zone whose type starts with "gpu", as the Qualcomm NPU backend does for "nsp". Without a devfreq the current clock is left unknown instead of showing the maximum.
The previous commit reads the GPU temperature from its thermal zones, so the MSM message no longer lists the temperature as missing.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The msm DRM interface has no query for the current GPU clock or temperature, so the msm backend shows the max clock as the current one and no temperature at all (see #204).
This reads both from sysfs: the clock from the GPU's devfreq, and the temperature from the hottest GPU thermal zone, such as
gpu-top-thermal. The devfreq is matched on theqcom,adrenocompatible, so the GMU is skipped. If a reading is unavailable, nvtop shows N/A for that field.Tested at idle and under load. The reported clock and temperature match the corresponding sysfs readings.