Repository navigation
Don't let the memory text overwrite the MEM label - #534
Open
cjolivier01 wants to merge 1 commit into
Open
cjolivier01 wants to merge 1 commit into
cjolivier01 wants to merge 1 commit into
Conversation
cjolivier01
force-pushed
the
upstream-fix/mem-meter-overflow
branch
from
October 17, 2026 17:10
fc849a9 to
64a68c5
Compare
cjolivier01
marked this pull request as ready for review
October 17, 2026 17:13
draw_percentage_meter() right-aligns the text by moving left from the closing bracket, so a string wider than the meter is drawn over the "MEM[" label rather than being clipped: GPU[ 0%] M123.456Gi/141.000Gi] ENC[ 0%] It needs a three-digit memory figure (H200, B200, MI300X) and a device panel narrow enough that MEM gets under 24 columns, which a short GPU name does. Fall back to a shorter form when the full one won't fit.
cjolivier01
force-pushed
the
upstream-fix/mem-meter-overflow
branch
from
October 17, 2026 17:16
64a68c5 to
fbe13a3
Compare
cjolivier01
marked this pull request as draft
October 17, 2026 17:18
cjolivier01
marked this pull request as ready for review
October 17, 2026 17:24
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
draw_percentage_meter()right-aligns the text inside the brackets by moving left from the closing bracket. When the text is wider than the meter it doesn't get clipped — it gets drawn over theMEM[label.Needs a three-digit memory figure, so a 141 GB H200 / 192 GB B200 / MI300X, plus a device panel narrow enough that MEM ends up under 24 columns — a short GPU name does that, since the panel is sized from the name.
Reproduced above by forcing
total_memoryto 141 GB and the panel width to 69 columns on master.The fix falls back to
123.5/141.0Giand then to whole units when the full form won't fit. Nothing changes for GPUs where it already fits.🤖 Generated with Claude Code