Repository navigation
Show fewer charts instead of none when they don't all fit - #535
Open
cjolivier01 wants to merge 1 commit into
Open
cjolivier01 wants to merge 1 commit into
cjolivier01 wants to merge 1 commit into
Conversation
cjolivier01
marked this pull request as ready for review
October 17, 2026 17:13
When no two charts can be merged without exceeding MAX_LINES_PER_PLOT, the layout gave up and set num_plot_stacks = 0, so the whole chart area disappeared. Three metrics on three GPUs is enough to hit it: 100x30, 3 GPUs, 2 metrics -> 3 charts 100x30, 3 GPUs, 3 metrics -> 0 charts Drop one chart and retry instead. An integrated GPU's goes first, since on a hybrid machine the discrete card is the one being watched.
cjolivier01
force-pushed
the
upstream-fix/charts-vanish
branch
from
October 17, 2026 17:16
cc30559 to
bdaf629
Compare
cjolivier01
marked this pull request as draft
October 17, 2026 17:18
cjolivier01
marked this pull request as ready for review
October 17, 2026 17:24
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When no two charts can be merged without exceeding
MAX_LINES_PER_PLOT,preliminary_plot_positioning()setsnum_plot_stacks = 0— so instead of showing fewer charts, it shows none.Above is two GPUs with four metrics each at 80x24. Driving
compute_sizes_from_layout()directly, three metrics on three GPUs is enough:With the fix those become 2, 3 and 5.
Drops one chart and retries rather than giving up. An integrated GPU's goes first — on a hybrid machine the discrete card is the one you're watching, and it's usually the higher index, so dropping the last plot would pick exactly the wrong one.
🤖 Generated with Claude Code