Eureka sprint 4 staging - #142
Merged
Merged
Conversation
This introduced no new significant code. The new code introduced just calls the existing `delete`, `build`, and `activate` commands. A `deploy` shall `build` and `activate`. A `redeploy` shall `delete`, `build`, and `activate`. A `404` on delete is considered not an error and the process continues on for `redeploy`. Add logging to each of the `delete`, `build`, and `activate` commands via a new optional parameter. This allows for the `deploy` and `redeploy` to print messages to help identify where each request is. The parameter defaults to `false` to preserve existing behavior.
Issue 136: Add support for deploy and redeploy commands.
The `service.deleteWorkflow()` call automatically sets the return status code to `2` on failure. In the case of redeploy, a `404` is not considered a failure. The `redeploy` command will continue on, but the return status code is still set to `2`! The program the exits with `2` when returning a success. Explicitly reset the resturn code to `0` when a `404` is received by the `delete` during a `redeploy`. This ensures a proper return code of `0` for cases when the `delete` returns a `404` only. A proper error return code will still happen if any other part of the process fails.
…g_on_redeploy Issue 136: Redeploy should not incorrectly return non-zero on success.
I thought the code was doing this but it turns out it was incomplete. This finished the logic and correctly runs on failure. Still print the actual response even if continuing.
Issue 136: Actually fail when not getting a 404 on delete.
- Explicitly delete `access` when generating check sum. - Explicitly delete `mod-camunda` when generating check sum. - Explicitly delete `mod-workflow` when generating check sum. - Also apply sort. - Update example manually check sum genereation code to also remove these.
There are several changes and also planned changes that change how `fw-cli` works. A minor version release bump makes sense here.
Issue 145: Fix check sums.
Update version to 1.1.0.
Issue 148: Switch to hard coded version.
Make the **CLI** related configuration variables explicitly clear by prefixing them with `cli`. Remove all unnecessary configuration variables. The `getAccess()`, now called `getAccessUrl()`, properly returns a **URL**. The `access` is now `cliAccess` and it accepts wither `direct` (in place of `mod-workflow`) and `gateway` (in place of `okapi`). The tokens now have `folio` prefixed to them. For example, `accessToken` is now `cliFolioAccessToken` (with cli also prefixed as noted above). The following non-cli variables are renamed: - `username` is now `folioUser`. - `password` is now `folioPass`. - `okapi-url` is now `gatewayUrl`. Note that ``folioUser` and `folioPass` are slated for removal once the `fw-registry` files are all updated to utilize the `FolioRequestDelegate` instead of `RequestDelegate`. The `tenant` is now removed. The `okapiLoginPath` is now removed. The `okapi` is now `cliGatewayUrl`. There is now a `cliFolioLoginPath`. Rename the `okapi.serverice.ts` to `gateway.service.ts`. Ensure that the `cliWd` always has a trailing slash. Empty strings for `cliWd` will use explicit relative directory of `./`. Update the check sum generation. Update the read me documentation.
…9_MODCAMUNDA-70 Issue 140: Refactor variables and structures for Eureka changes.
This allows for fw-registry to still exist in fw-cli without concern.
Updated the read me file to reference `gateway` rather than `okapi`. It turns out there is a typo in the `gateway.js`, so fix that too.
This was overlooked in the previous changes that were for resolving Issue 140.
Break out the `cliFolioAccessToken`, `cliFolioRefreshToken`, `cliFolioToken`, and `cliUserId` into a separate cache file. I just noticed that we have a linter. Run the linter and fix all problems found. Add command line parameters: - `-C` for showing the cache. Add command line commands: - `cache`. Currently only `clear` is supported for the cache.
…dules Issue 133: Remove all sub-modules.
Issue 152: Update copyright year to 2026.
Issue 140: Rename username to cliFolioUser.
Issue 144: Use cache file.
…_load Issue 156: Clear config before loading new config.
kaladay
marked this pull request as ready for review
August 26, 2026 15:59
rmathew1011
approved these changes
Aug 26, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What's Changed