Repository navigation
refactor: replace Any annotations and enforce ANN401 - #257
Merged
Merged
Conversation
Phase 3 of the ANN cleanup: all 25 ANN401 violations are gone, so ANN401 joins the ruff select list and is now enforced by CI instead of merely counted by the lint budget. Replaces Any with the real types (type, TextSegment, a typed rewrite-action Callable, list[str], dict[str, str]). The parametrized boolean test parameters became keyword-only, as ruff's FBT001 requires; pytest supplies them by keyword. Lowers the ruff budget by 37 and the pyright budget by 12.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Phase 3 of the ANN cleanup: all 25 ANN401 violations are gone, so ANN401 joins the ruff select list and is now enforced by CI instead of merely counted by the lint budget.
Replaces Any with the real types (type, TextSegment, a typed rewrite-action Callable, list[str], dict[str, str]). The parametrized boolean test parameters became keyword-only, as ruff's FBT001 requires; pytest supplies them by keyword. Lowers the ruff budget by 37 and the pyright budget by 12.