feat(classifier): recognise cosign hardware-key signing touches - #13
Draft
Talgarr wants to merge 3 commits into
Draft
feat(classifier): recognise cosign hardware-key signing touches#13Talgarr wants to merge 3 commits into
Talgarr wants to merge 3 commits into
Conversation
cosign (Sigstore) can sign with a PIV hardware token (touch-policy=always) via its go-piv / PKCS#11 backend, so a sustained touch-wait while cosign runs is a hardware-key signing request. Classify sign / sign-blob / attest / generate-key-pair subcommands and extract the image ref or blob resource. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Add an e2e check that signs a scratch blob with `cosign sign-blob` using a PIV PKCS#11 key (touch-policy=always) supplied via WHENCE_E2E_COSIGN_KEY, asserting the classifier named `cosign`. Skips when cosign or the key is absent. Register it in the driver and document it. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
The cosign e2e test drives `cosign sign-blob`; add it so it lands on PATH in `nix develop`. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
cosign (Sigstore) can sign with a PIV hardware token (touch-policy=always) via its go-piv / PKCS#11 backend, so a sustained touch-wait while cosign runs is a hardware-key signing request. Classify sign / sign-blob / attest / generate-key-pair subcommands and extract the image ref or blob resource.