Fix version strings in standalone bazel build - #308
Conversation
…ct#308) This prevents the thundering herd problem and should increase the scalability of the DispatchQueue significantly. Additionally the code the DispatchQueue was taken from made this improvement five years ago: embeddedartistry/embedded-resources@79ad8a5 Signed-off-by: Drew Lewis <cannada@google.com>
dsengupta0628
left a comment
dsengupta0628
left a comment
There was a problem hiding this comment.
The PR sets STA_VERSION "3.0.0" but CMakeLists.txt line 27 has: project(STA VERSION 3.1.0
These should be consistent. Either this PR should use 3.1.0, or there's a deliberate reason for the difference. Please check
Please sync to latest OpenSTA as I have some changes in this file to take in the string squash change from upstream OpenSTA
|
Who are you asking to sync? |
My bad! I meant this for the PR author @povik |
Replace the hard-coded hash with a value fetched through the same
mechanism used for openroad. Also bump the tool version. This requires
changes to the workspace_status.sh script on the OR end.
When the hash is available (with --stamp):
$ bazel-bin/src/sta/opensta
OpenSTA 3.0.0 16ac05c Copyright (c) 2025, Parallax Software, Inc.
When it's not:
$ bazel-bin/src/sta/opensta
OpenSTA 3.0.0 unknown Copyright (c) 2025, Parallax Software, Inc.
Signed-off-by: Martin Povišer <povik@cutebit.org>
|
It's possible 3.0.0 was current when I originally wrote it. In any case I have rebased and bumped version to 3.1.0. |
|
@dsengupta0628 this seems to have gotten lost. If still relevant please take over. |
yes pushing updates in the same PR and also reopening The-OpenROAD-Project/OpenROAD#9711 |
4 participants
Replace the hard-coded hash with a value fetched through the same mechanism used for openroad. Also bump the tool version. This requires changes to the workspace_status.sh script on the OR end.
When the hash is available (with --stamp):
When it's not: