dcalc: Restore TwoPole parasitic reduction - #407
Open
jhkim-pii wants to merge 2 commits into
Open
Conversation
Override the TwoPole reduction hook so eager parasitic reduction creates PiPoleResidue2 instead of inheriting the PiElmore implementation. This restores calculator-specific dispatch for placement and reduced SPEF paths. Signed-off-by: Jaehyun Kim <jhkim@precisioninno.com>
Exercise eager reduction on a detailed SPEF network and verify dmp_ceff_two_pole returns a PiPoleResidue model. This prevents the calculator from silently inheriting PiElmore reduction again. Signed-off-by: Jaehyun Kim <jhkim@precisioninno.com>
There was a problem hiding this comment.
Code Review
This pull request implements the reduceParasitic method in DmpCeffTwoPoleDelayCalc to reduce a parasitic network to a Pi-pole residue, and adds a corresponding unit test to verify this functionality. The feedback suggests adding a null check for the parasitics pointer retrieved from the scene to prevent a potential null pointer dereference before calling reduceToPiPoleResidue2.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Problem
Solution
Impact
Related