Adapt to timely #817, #818, #819 - #877
Merged
Merged
Conversation
InputCapability::time() requires TotalOrder and returns Option (#817). Operators that read a time off a capability are gone (#818), as is unary_notify (#819). The three leave_dynamic operators (vec, columnar, corgi) hold a capability per stamp element, truncated as the records are. Collection::delay delays each stamp element and each update's time and sends at once, without timely's delay_batch. Collection::inspect_batch hands the closure the batch's Stamp; inspect_container is inspect_core. upsert takes retain_least; capture holds a CapabilitySet from retain_stamp; half_join inserts each element of retain_stamp. The diagnostics loggers take least() and skip a message with an empty stamp. The dogsdogsdogs examples count with DD's count; graphs-static no longer delays records to their times. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01SFY2AqDJTLX9TRGRuGR8dQ
Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01SFY2AqDJTLX9TRGRuGR8dQ
frankmcsherry
added a commit
that referenced
this pull request
Sep 21, 2026
`advent_of_code_2017`, `tpchlike` and `doop` are commented out of `workspace.members` and are not in `workspace.exclude` either, so they cannot be built by any route — a standalone `cargo check` fails with "current package believes it's in a workspace when it's not". They have missed the last several API migrations. `experiments`, `diagnostics` and `dogsdogsdogs` were updated for timely #817-#819 in \#877; these three were not, and were last touched in #724 (April) and \#673 (February). Nothing outside their own trees references them beyond the three commented `members` lines removed here. 13,294 lines, ~21% of the repository's Rust. Co-authored-by: Claude Opus 5 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Catches differential-dataflow up to timely master (4eb3ee09):
InputCapability::time()requiresTotalOrderand returnsOption(#817), operators that read a time off a capability are removed (#818), andunary_notifyis removed (#819).master-nextdoes not build against timely master without this.leave_dynamicoperators (vec, columnar, corgi) hold a capability per element of the message's stamp, truncated as the records are. Their time is a partial order, so there is no least element to take.Collection::delayno longer uses timely'sdelay_batch. It delays each stamp element and each update's time throughfuncand sends at once under the delayed capabilities, which works for partial orders; theT: Hashbound is gone.Collection::inspect_batchhands the closure the batch'sStamp<T>;Collection::inspect_containeris renamedinspect_core.retain_least; capture's CDC progress operator holds aCapabilitySetfromretain_stamp; dogsdogsdogshalf_joininserts each element ofretain_stamp.least()and skip a message with an empty stamp.count;graphs-staticno longer delays records to their times, as the reduce acts on record times.This replaces #874 and the timely parts of #855; #855's stamp routing at the batch-to-records seams is not included.
Tests (all targets), doctests, clippy, and the
explainrelease test pass locally against timely 4eb3ee09.🤖 Generated with Claude Code
https://claude.ai/code/session_01SFY2AqDJTLX9TRGRuGR8dQ