Repository navigation
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Policycarriesfrom,fromAgentandfromRole, but notfor— so a policy built with this library cannot say which party it applies to, and the field is dropped when an inbound message is parsed and re-serialised.TAIP-7 uses
foralongsidefromon all three policy types, and implementations read it: one gateway we interoperate with feedspolicy.forto its presentation request as the DID to present to, so a policy that omits it arrives with nobody to answer.This adds the field next to
from, withomitemptyto match the rest of the struct, plus a round-trip test mirroringTestPolicy_FromFieldRoundTrip.go test ./...andgo vet ./...pass.