ci: publish through npm trusted publishing - #399
Merged
Conversation
The release job exchanges its OIDC token for a registry one instead of carrying `NPM_TOKEN`. `registry-url` is dropped from `actions/setup-node`: it writes a placeholder `_authToken` into `.npmrc` that would shadow the exchange.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #399 +/- ##
==========================================
+ Coverage 98.34% 98.47% +0.12%
==========================================
Files 5 5
Lines 121 131 +10
Branches 31 35 +4
==========================================
+ Hits 119 129 +10
Misses 2 2 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Moves publishing from a long-lived
NPM_TOKENto npm OIDC trusted publishing.releasejob getspermissions: id-token: write— without a permissions block GitHub issues no OIDC token — pluscontents: write, which the action needs for the tag and the GitHub release.npm-tokenis no longer passed tosimple-release-action. Publishing goes through@simple-release/pnpm, and pnpm performs the token exchange itself since 10.9; this workflow installs 11.registry-urlis dropped fromactions/setup-node. It writes a placeholder_authTokenline into.npmrc, and that would shadow the exchange.There is no snapshot workflow here, so the "one trusted publisher per package" limit needs no workarounds.
Before this can publish
The trusted publisher has to exist on the npm side, pointing at this workflow file:
Afterwards the
NPM_TOKENrepository secret is unused and can be deleted.