fix(compatibility): construct string_view by length, not by iterator pair - #969
Merged
Conversation
mikolajmikolajczyk
force-pushed
the
fix/string-view-cxx17
branch
from
August 20, 2026 17:45
886ae3e to
a2c4fd2
Compare
…pair basic_string_view(It first, End last) is C++20 and libc++ 11 does not have it; the call fails with "no matching constructor". The length form is C++17, exists in both libraries, and denotes the same view - ptr..ptr+size is a range of length size.
mikolajmikolajczyk
force-pushed
the
fix/string-view-cxx17
branch
from
August 20, 2026 17:50
a2c4fd2 to
6338fd7
Compare
Owner
|
Merged, thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
basic_string_view(It first, End last) is C++20 and libc++ 11 does not have it. The call fails with "no matching constructor".
The length form is C++17, exists in both libraries, and denotes the same view - ptr..ptr+size is a range of length size.