chore(ui5-combobox): improve accessibility when items are loaded with delay - #13930
Open
nikoletavnv wants to merge 6 commits into
Open
chore(ui5-combobox): improve accessibility when items are loaded with delay#13930nikoletavnv wants to merge 6 commits into
nikoletavnv wants to merge 6 commits into
Conversation
|
🚀 Deployed on https://pr-13930--ui5-webcomponents-preview.netlify.app |
|
|
ivoplashkov
requested changes
Aug 18, 2026
ivoplashkov
left a comment
ivoplashkov
left a comment
Contributor
There was a problem hiding this comment.
- I think we should remove the second example from the playground "Load all on open, filter on the client". I don't think it brings value that the other two samples don't. Also it has an issue if you open the picker with [Alt] + [Down], then [ArrowDown] to select an item and type "D", list get refreshed and items are doubled.
- When the initial load of the items happens (sample in playground), when i start typing, value is autocompleted and at the same time loading is shown which indicates that the items are being loaded. Should we fix this in the sample?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The change enhances screen reader announcement when a loading of items starts and ends. It also introduces a new event 'load-items' that users can use in order to set the
ui5-comboboxcomponent in a loading state while items are created/fetched by the application.JIRA: BGSOFUIRILA-4491