Skip to content

trunk shadow changes: com.unity.ml-agents - #6322

Open
pets-svc[bot] wants to merge 1 commit into
release/4.1.0from
shadow-package/com.unity.ml-agents
Open

trunk shadow changes: com.unity.ml-agents#6322
pets-svc[bot] wants to merge 1 commit into
release/4.1.0from
shadow-package/com.unity.ml-agents

Conversation

@pets-svc

@pets-svc pets-svc Bot commented Aug 7, 2026

Copy link
Copy Markdown

This PR contains changes made to the trunk copy of com.unity.ml-agents.tests.

Please review the test changes and incorporate them into your test package as appropriate, before your next package release.

The bot commit c52b356 was created on top of the package release commit. You may need to cherrypick the commit to a freshly created branch.

Is this automation useful? Let us know on #devs-pets, where you can also ask any question you might have about shadow packages or this automation.

Note: The shadow-package/com.unity.ml-agents branch may be force-pushed by automation at any time. If you want to make changes before landing this PR, create your own branch (and PR) to avoid automation overwriting your changes:

git fetch origin shadow-package/com.unity.ml-agents:mybranch
git checkout mybranch

If further changes are made to the shadow package on trunk, this PR will be updated if still open, or else a new PR will be opened.

@CLAassistant

CLAassistant commented Aug 7, 2026

Copy link
Copy Markdown

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

@u-pr u-pr Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Harness Review

Needs changes

The release update introduces broad test suppression, leaving important validation paths unexercised in CI.

Reviewed commit a9eda55

🤖 Helpful? 👍/👎

using NUnit.Framework;
using Unity.MLAgents.Sensors;
using UnityEngine;
#if !UNITY_EDITOR_WIN

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P1

This condition is applied to every one of the 41 C# sources under Tests/Editor, including the Public API assembly. Both test assemblies still target the Editor, and the generated Windows validation jobs invoke the editor test suite; with UNITY_EDITOR_WIN defined, those jobs compile no ML-Agents Editor fixtures at all. Consequently Windows CI can pass while all Editor behavior is untested. Restore the suite, or isolate and track only the specific failing tests instead of conditionally removing every fixture.

🤖 Helpful? 👍/👎


namespace Unity.MLAgents.Tests
{
[Ignore("Temporary")]

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P1

A fixture-level Ignore skips every test in this class on every platform. That includes TestStackedGetCompressedObservationMultiChannel, the only direct coverage found for the four-channel compressed-stacking path described as fixed in this release. CI will therefore no longer validate that path and a regression will be reported as a passing run with skipped tests. Re-enable the fixture (or narrowly skip only a documented failing case) before release.

🤖 Helpful? 👍/👎

@pets-svc
pets-svc Bot force-pushed the shadow-package/com.unity.ml-agents branch 2 times, most recently from 96bc325 to 502d88a Compare August 14, 2026 00:36
@pets-svc
pets-svc Bot changed the base branch from develop to release/4.1.0 August 15, 2026 09:42
@pets-svc
pets-svc Bot force-pushed the shadow-package/com.unity.ml-agents branch from 502d88a to c52b356 Compare August 25, 2026 08:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant