Repository navigation
chore(release): drop the update-changelog-data job - #1145
Conversation
The safe-docx site only redirects to usejunior.com (#47), so nothing publishes site/src/_raw/changelog.json; the job opened PRs for data no one reads. The generator script stays for manual refreshes, and the runbook now says so. Also correct the upload-sarif pin comment in semgrep.yml: the SHA is codeql-action v4.38.2, not v3.
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
LLM gate (advisory)All evaluated rules passed - 3 pass, 0 warn, 0 error, 13 skipped, 16 total FindingsNone. All 16 rules (3 evaluated, 13 skipped)
|
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: b33157cb92
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| The release workflow no longer regenerates `site/src/_raw/changelog.json`: the | ||
| safe-docx site only redirects to usejunior.com, so nothing publishes it. To | ||
| refresh it manually: |
There was a problem hiding this comment.
When the next release runs, no job will open a changelog PR, but the verification checklist at line 94 still requires operators to confirm that such a PR was opened and merged. This directly contradicts the new manual-refresh guidance here and leaves every release with an impossible checklist item; remove or replace that verification step.
Useful? React with 👍 / 👎.
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
This branch was successfully deployed
1 participant
Summary
update-changelog-datajob fromrelease.yml. It was the last job and nothing depends on it. The safe-docx site only redirects to usejunior.com since feat(seo): activate 301 redirects to usejunior.com #47, so thechangelog.jsonPRs it opened fed nothing that is published.scripts/generate_changelog_data.mjs,scripts/check_changelog_data.mjsandsite/src/_raw/changelog.json: the site source and the offline checker still read them.docs/release-runbook.mdnow describes refreshing it manually.upload-sarifpin comment insemgrep.yml(# v3→# v4.38.2; the SHA2892aa5eis already v4.38.2 — same SHA as the init/analyze pins from chore(ci): bump codeql-action init and analyze to v4.38.2 #1141).Verification
actionlinton both workflows: clean.node scripts/check-release-isolation.mjs: passed.grep update-changelogacross.github,docs,scripts,package.json: no references remain.