Normalize Dublin Core <dc:date> in PdfNormalizer#517
Open
moni-dips wants to merge 1 commit into
Open
Conversation
PdfNormalizer zeroed the xmp:CreateDate/ModifyDate/MetadataDate elements but not the Dublin Core <dc:date> element. Apache FOP writes the render timestamp into <dc:date>, so the #pdf snapshot target (added in VerifyTests#516) was non-deterministic for FOP-produced PDFs while the sibling dates were neutralized. Adds <dc:date> to the normalized set plus a focused test.
Member
|
i think it is a little more complex #519 can u try 3.3.1 |
Author
|
yes, I agree, my change was just a quick naïve fix. and this is the .verified. file from git: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PdfNormalizer zeroed the xmp:CreateDate/ModifyDate/MetadataDate elements but not the Dublin Core dc:date element.
Apache FOP writes the render timestamp into dc:date, so the #pdf snapshot target (added in #516) was non-deterministic for FOP-produced PDFs while the sibling dates were neutralized.
This PR adds dc:date to the normalized set together with a focused test.