Skip to content

Recompile components compiled inside with_new_cache #2735

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
joelhawksley merged 2 commits into from
Oct 22, 2026
Merged

Recompile components compiled inside with_new_cache #2735

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
a782d17
Recompile components compiled inside with_new_cache
anthony0030 Oct 22, 2026
ecb933a
Add changelog entry for the with_new_cache fix
anthony0030 Oct 22, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions docs/CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,6 +10,10 @@ nav_order: 6

## main

* Fix the template annotations integration test failing when it ran after the coverage compile tests, which left components compiled without the annotation in the test cache.

*Anthony Veaudry*

## 4.18.0

* Enable caching support for all components by default, and rename `ViewComponent::ExperimentallyCacheable` to `ViewComponent::Cacheable`. Including the module is no longer necessary. Breaking: remove existing `include ViewComponent::ExperimentallyCacheable` lines. Caching is no longer experimental.
Expand Down
3 changes: 3 additions & 0 deletions test/test_helper.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -137,6 +137,9 @@ def with_new_cache
yield
ensure
ActionView::Base.cache_template_loading = old_cache_template_loading
# Components compiled in the block were compiled under its settings, such as
# coverage or annotations, so make them compile again the next time they render.
old_cache.subtract(ViewComponent::CompileCache.cache)
ViewComponent::CompileCache.cache = old_cache
end

Expand Down
Loading