GUI: draw framebuffer updates without temporary pixmaps#745
Draft
moreaki wants to merge 1 commit into
Draft
Conversation
|
Thank you for your pull request and welcome to our community! To contribute, please sign the Oracle Contributor Agreement (OCA).
To sign the OCA, please create an Oracle account and sign the OCA in Oracle's Contributor Agreement Application. When signing the OCA, please provide your GitHub username. After signing the OCA and getting an OCA approval from Oracle, this PR will be automatically updated. If you are an Oracle employee, please make sure that you are a member of the main Oracle GitHub organization, and your membership in this organization is public. |
moreaki
marked this pull request as ready for review
July 8, 2026 08:09
moreaki
marked this pull request as draft
July 9, 2026 08:49
Draw the damaged source rectangle directly from the framebuffer QImage instead of materializing a QPixmap for every paint. Keep the macOS destination explicitly opaque before compositing so black boot frames do not become gray or transparent. Signed-off-by: Roberto Nibali <rnibali@gmail.com>
moreaki
force-pushed
the
agent/macos-frontend-repaint-overhead
branch
from
July 16, 2026 15:58
e4f1e18 to
b44df3d
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Draw framebuffer update rectangles directly from the backing
QImageinstead of constructing a temporaryQImageview and converting it to aQPixmapfor every painted rectangle.The direct
QPainter::drawImagecall preserves the existing source rectangle, logical target position, and device-pixel-ratio scaling. The patch is confined toUIFrameBufferPrivate::drawImageRect; it does not alter Dock previews, opacity, background clearing, widget attributes, update scheduling, or platform policy.Scope
This is a draft Qt frontend performance candidate, not a functional prerequisite for the Retina/HiDPI work tracked by #742. It should remain draft—and should be closed if an isolated current-main A/B comparison does not show a repeatable benefit.
Benchmark source
The validation tool is the fixed
dxmtbenchfunctional/performance harness. Performance samples are admissible only after the same run passes its browser framebuffer, guest screenshot, host presentation/signature, launch, and graphics-log gates.Validation
git diff --check: passed.origin/mainwith this patch in the integrated functional stack: pending after the final minimization.Earlier measurements covered a larger combined patch and are not evidence for this minimized PR.
Refs #742.