GUI: resend guest resize on macOS fullscreen transition#746
Draft
moreaki wants to merge 1 commit into
Draft
Conversation
|
Thank you for your pull request and welcome to our community! To contribute, please sign the Oracle Contributor Agreement (OCA).
To sign the OCA, please create an Oracle account and sign the OCA in Oracle's Contributor Agreement Application. When signing the OCA, please provide your GitHub username. After signing the OCA and getting an OCA approval from Oracle, this PR will be automatically updated. If you are an Oracle employee, please make sure that you are a member of the main Oracle GitHub organization, and your membership in this organization is public. |
When a macOS fullscreen resize reaches the host screen size, invoke the existing guest-resize helper. That helper already converts logical host dimensions to Retina backing dimensions. Signed-off-by: Roberto Nibali <rnibali@gmail.com>
acad7bb to
caf0d84
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
When the macOS fullscreen machine view reaches its calculated maximum size, call the existing guest-resize helper if guest autoresize is enabled and the guest supports graphics.
The change is four macOS-only lines in
UIMachineViewFullscreen::eventFilter. It does not add a new scaling calculation:sltPerformGuestResizealready converts the host logical geometry to Retina backing pixels.Narrow premise
The suspected failure is a windowed-to-fullscreen transition of an already-running guest. Reproduction must therefore use this sequence:
VideoModeand ascreenshotpng;Starting the VM directly with
VirtualBoxVM --startvm Win11 --fullscreenis not a valid A/B for this PR. In the clean current-main-based comparison, both patched and unpatched variants reached 5760x3240 during startup through the existing initialization path.Validation status
Completed:
origin/mainat5ac81eda707fcf3fcb49f9281401ceac0fc70f4a;git diff --checkpasses;VirtualBoxVMtarget;VideoMode="5760,3240,32"@0,0 1, and produces a 5760x3240 framebuffer screenshot.Still required:
This PR should be closed if the controlled transition produces the same result without the change.
Refs #742.