Additions/WDDM: add Retina-scaled video modes#749
Conversation
Signed-off-by: Roberto Nibali <rnibali@gmail.com>
|
Thank you for your pull request and welcome to our community! To contribute, please sign the Oracle Contributor Agreement (OCA).
To sign the OCA, please create an Oracle account and sign the OCA in Oracle's Contributor Agreement Application. When signing the OCA, please provide your GitHub username. After signing the OCA and getting an OCA approval from Oracle, this PR will be automatically updated. If you are an Oracle employee, please make sure that you are a member of the main Oracle GitHub organization, and your membership in this organization is public. |
|
Withdrawing because the changed WDDM mode-enumeration path has not been compiled with the Windows WDK, installed, or exercised. The existing screenshots used the driver custom-mode registry path and therefore do not validate this code change. A replacement should include a VBoxWddm build, installation, and mode-list capture produced by the changed enumeration path. |
Summary
Add aspect-preserving intermediate modes to the Windows Guest Additions WDDM mode list.
For a
5760x3240Retina target, the generated modes are:5120x28803840x21603200x18002880x16202560x14401920x1080Why
The previous built-in WDDM list exposed the native Retina target mode and then mostly legacy 4:3/5:4 modes such as
1920x1440,1600x1200, and1280x1024. That made Windows Display Settings awkward for high-DPI hosts because useful aspect-correct intermediate Retina modes were missing.The new code derives scaled modes from the current/preferred target size and keeps the existing VRAM/frontend mode checks.
Validation
origin/main.git diff --checkpasses.VBoxWddmbuild was attempted, but the local macOS ARM64 tree lacks a configured Windows SDK/WDK (PATH_SDK_WINSDK10), so the build stopped before compiling the driver.Refs #742.