Repository navigation
Conversation
For PRs that use branches in the upstream repo, we can automatically generate the markdown files and add a commit to the PR with the change, so that users can just directly edit the json file in the github UI. For forked PRs we can't do that, and for PRs that already update the markdown files, we don't clobber their changes; instead just validate.
This reverts commit 5eba918.
This reverts commit cd4c452.
Member
Author
|
You can see where I tested the change by updating this PR itself. |
tlively
reviewed
Oct 6, 2026
tlively
left a comment
tlively
left a comment
Member
There was a problem hiding this comment.
Nice! Can you manually test the PR-from-fork workflow as well? (e.g. with a PR forked from and targeting this branch)
| python generate_markdown.py | ||
| if ! git diff --quiet -- README.md finished-proposals.md inactive-proposals.md; then | ||
| git config user.name 'github-actions[bot]' | ||
| git config user.email '41898282+github-actions[bot]@users.noreply.github.com' |
Member
Author
There was a problem hiding this comment.
It's the user ID for the github-actions[bot] app (https://api.github.com/users/github-actions%5Bbot%5D). Gemini tells me it's not strictly necessary but makes the link to the avatar work correctly. (It is apparently necessary to configure the git user and email though).
Member
Author
oh, sorry I missed this request earlier. Seems to work! #246 |
tlively
approved these changes
Oct 7, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
For PRs that use branches in the upstream repo, we can automatically
generate the markdown files and add a commit to the PR with the change,
so that users can just directly edit the json file in the github UI.
For forked PRs we can't do that, and for PRs that already update the
markdown files, we don't clobber their changes; instead just validate.