Skip to content

Tests: Make data providers in tests/phpunit/tests/admin/includes/misc/ public static #15309

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
devmuhib009 wants to merge 1 commit into from
+4 −4
Closed

Tests: Make data providers in tests/phpunit/tests/admin/includes/misc/ public static #15309

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion tests/phpunit/tests/admin/includes/misc/gotModRewrite.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -78,7 +78,7 @@ static function ( $got_rewrite ) use ( $filter_value, &$filtered_value ) {
* filter_value: bool,
* }>
*/
public function data_got_mod_rewrite(): array {
public static function data_got_mod_rewrite(): array {
return array(
'Apache, filter returns true' => array(
'is_apache' => true,
Expand Down
2 changes: 1 addition & 1 deletion tests/phpunit/tests/admin/includes/misc/iis7AddRewriteRule.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -68,7 +68,7 @@ public function test_iis7_add_rewrite_rule( $initial_content, $rewrite_rule, $ex
* expected_content: string,
* }>
*/
public function data_iis7_add_rewrite_rule(): array {
public static function data_iis7_add_rewrite_rule(): array {
$rule = '<rule name="wordpress" patternSyntax="Wildcard"><match url="*" /><conditions><add input="{REQUEST_FILENAME}" matchType="IsFile" negate="true" /><add input="{REQUEST_FILENAME}" matchType="IsDirectory" negate="true" /></conditions><action type="Rewrite" url="index.php" /></rule>';

return array(
Expand Down
2 changes: 1 addition & 1 deletion tests/phpunit/tests/admin/includes/misc/iis7RewriteRuleExists.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -60,7 +60,7 @@ public function test_iis7_rewrite_rule_exists( $expected, $content ) {
*
* @return array<string, array{expected: bool, content: string}>
*/
public function data_iis7_rewrite_rule_exists(): array {
public static function data_iis7_rewrite_rule_exists(): array {
return array(
'Rule with name starting with "wordpress" exists' => array(
'expected' => true,
Expand Down
2 changes: 1 addition & 1 deletion tests/phpunit/tests/admin/includes/misc/wpMakePluginFileTree.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,7 +29,7 @@ public function test_wp_make_plugin_file_tree( $plugin_editable_files, $expected
* expected: array<string, mixed>,
* }>
*/
public function data_wp_make_plugin_file_tree(): array {
public static function data_wp_make_plugin_file_tree(): array {
return array(
'empty_list' => array(
'plugin_editable_files' => array(),
Expand Down
Loading