Repository navigation
Tests: Cover post_type_archive_title() #15319
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
devmuhib009
wants to merge
1
commit into
WordPress:trunk
from
devmuhib009:tests/65819-cover-post-type-archive-title
Closed
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,95 @@ | ||
| <?php | ||
|
|
||
| /** | ||
| * Tests for the `post_type_archive_title()` function. | ||
| * | ||
| * @group general | ||
| * @group template | ||
| * | ||
| * @covers ::post_type_archive_title | ||
| */ | ||
| class Tests_General_PostTypeArchiveTitle extends WP_UnitTestCase { | ||
|
|
||
| const POST_TYPE = 'wptests_pt'; | ||
|
|
||
| public function set_up() { | ||
| parent::set_up(); | ||
|
|
||
| register_post_type( | ||
| self::POST_TYPE, | ||
| array( | ||
| 'public' => true, | ||
| 'has_archive' => true, | ||
| 'labels' => array( | ||
| 'name' => 'Custom Books', | ||
| ), | ||
| ) | ||
| ); | ||
| } | ||
|
|
||
| /** | ||
| * Tests that post_type_archive_title() returns null when not on a post type archive. | ||
| * | ||
| * @ticket 65819 | ||
| */ | ||
| public function test_post_type_archive_title_returns_null_outside_archive() { | ||
| $this->go_to( '/' ); | ||
|
|
||
| $this->assertNull( post_type_archive_title( '', false ) ); | ||
| } | ||
|
|
||
| /** | ||
| * Tests that post_type_archive_title() displays the title on a post type archive. | ||
| * | ||
| * @ticket 65819 | ||
| */ | ||
| public function test_post_type_archive_title_should_display_on_archive() { | ||
| $this->go_to( '/?post_type=' . self::POST_TYPE ); | ||
|
|
||
| $this->expectOutputString( 'Custom Books' ); | ||
| post_type_archive_title(); | ||
| } | ||
|
|
||
| /** | ||
| * Tests that post_type_archive_title() returns the title when $display is false. | ||
| * | ||
| * @ticket 65819 | ||
| */ | ||
| public function test_post_type_archive_title_returns_when_display_is_false() { | ||
| $this->go_to( '/?post_type=' . self::POST_TYPE ); | ||
|
|
||
| $this->assertSame( 'Custom Books', post_type_archive_title( '', false ) ); | ||
| } | ||
|
|
||
| /** | ||
| * Tests that post_type_archive_title() prepends the prefix to the title. | ||
| * | ||
| * @ticket 65819 | ||
| */ | ||
| public function test_post_type_archive_title_prepends_prefix() { | ||
| $this->go_to( '/?post_type=' . self::POST_TYPE ); | ||
|
|
||
| $this->expectOutputString( 'Archive: Custom Books' ); | ||
| post_type_archive_title( 'Archive: ' ); | ||
| } | ||
|
|
||
| /** | ||
| * Tests that post_type_archive_title() respects the post_type_archive_title filter. | ||
| * | ||
| * @ticket 65819 | ||
| */ | ||
| public function test_post_type_archive_title_filter() { | ||
| $this->go_to( '/?post_type=' . self::POST_TYPE ); | ||
|
|
||
| add_filter( | ||
| 'post_type_archive_title', | ||
| static function ( $title, $post_type ) { | ||
| return 'Filtered: ' . $title . ' (' . $post_type . ')'; | ||
| }, | ||
| 10, | ||
| 2 | ||
| ); | ||
|
|
||
| $this->assertSame( 'Filtered: Custom Books (wptests_pt)', post_type_archive_title( '', false ) ); | ||
|
Member
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Another small gap: the |
||
| } | ||
| } | ||
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This one looks like a small coverage gap: the prefix is only tested when displaying, so a lost prefix in
return $prefix . $titlegoes unnoticed. Could you add$this->assertSame( 'Archive: Custom Books', post_type_archive_title( 'Archive: ', false ) );?