Repository navigation
battle: type the callback queue slots and name the detached queue - #279
Merged
Merged
Conversation
Type both callback queues' slots as unions of per-consumer views, decompile func_800C494C and func_800C5694, and name BattleEffectUpdate and the screen-fade globals.
eduardovra
marked this pull request as ready for review
October 8, 2026 02:35
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Continuing from #268, this types the slots of the two battle callback queues. Each slot is now a union of the views its callbacks use, so they can read named fields instead of raw offsets. Most of the diff is mechanical renames that follow from that, plus a couple of newly decompiled functions that helped figure out the names.
It also names the second queue, at 0x801621F0. It looks like a sibling of the Effect queue, except there is no code polling its status waiting for it to finish, so my best guess for a name was "Detached", but I'm open to suggestions. One example of that polling is BattleFadeInAfterSummon: it runs on the detached queue itself, and waits for g_BattleEffectCount to reach 0 (every effect callback finished) before fading the party back in.