Repository navigation
Match only a trailing :80 when comparing responder URLs - #216
Merged
Merged
Conversation
… :8000 stay distinct The default-port check searched for ':80' anywhere in the authority, so two different non-default ports sharing that prefix were treated as the same responder and one was never tried. It now checks the suffix, and the dedup test covers the pair.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
UrlIdentity looked for ':80' anywhere in the authority, so
http://a.test:8080/andhttp://a.test:8000/collapsed to one responder and the second was skipped. It now compares the authority's suffix, and TestDedupEquivalenceEdges asserts the two stay distinct.