Repository navigation
Correct RFC citations and stale docs - #226
Merged
Merged
Conversation
…nd docs A closing review checked every RFC citation in the tree against the RFC text. Most were right; this fixes the ones that were not: - Section numbers that pointed at the wrong place (RFC 8446 4.4.2 for the MD5/SHA-1 rule is 4.4.2.4, the ticket-age freshness window is 8.3 not 8.2, RFC 7469 pinning is 2.6, the ECH SvcParamKey is RFC 9848, RFC 8422's curve rules are 5.3, and so on), and a few citations of an RFC for something it does not define (an asynchronous verdict, a tag in a test string). - RFC 6125 is replaced by RFC 9525, which obsoletes it. The README no longer says CN matching is off by default; there is no CN matching at all. - Comments that named another implementation's helpers, or described a mechanism rather than the reason, are cut down to the reason. - Docs: add SecP256r1MLKEM768 to the preset group lists and the supported signature schemes, state that imported PSKs need both peers to implement RFC 9258, fix two examples that leaked or took the wrong first argument, and list the extensions the library actually handles. Comments, docs and one resourcestring only; no behaviour changes.
…round them RFC 8422 2.1 is the ECDHE_ECDSA rule (not 2.2), the CRL point check cites only the cRLIssuer rule it applies, a missed RFC 9846 reference is RFC 8446 again, and a secure-connection renegotiation refusal rests on RFC 5246 7.2.2 alone (RFC 5746 4.2 and 4.4 cover other cases). Drop two stretched citations, a comment that narrated history and one that described a return value, and rewrap the longest added lines.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A review checked every RFC citation in the tree against the RFC text. Most were right. This fixes the ones that were not, and the docs that had drifted from the code.
bogo-shim-config.json: description text only.Comments and docs only, plus one resourcestring citation in the FclNet adapter. FPC x86_64 and i386 1464, Delphi Win32 1464, comment-lint and guid-lint clean.