Repository navigation
fix(limits): HLS media skips the general limiter; 429s say when to retry - #271
Merged
Merged
Conversation
With the shipped limits (one request a second, burst 120) a four-tile HLS montage, about four playlist and segment fetches a second, ran the bucket dry within a minute and then got 429s until the tiles gave up. WebRTC montages were fine. GET requests for a live session's playlists, init segment and media segments now skip the general limiter. A session already gates them, and starting the session still goes through it. hls/link stays limited. tower_governor rounds the wait down to whole seconds, so with one token a second every 429 carried retry-after: 0, and a client that honoured it came straight back. The 429 now rounds up (at least 1 s), on the auth limiter too. Fixes #257 Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01KXE4e1KGijmQSLUde9ydBZ
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
With the shipped limits (one request a second, burst 120) a four-tile
HLS montage, about four playlist and segment fetches a second, ran the
bucket dry within a minute and then got 429s until the tiles gave up.
WebRTC montages were fine.
GET requests for a live session's playlists, init segment and media
segments now skip the general limiter. A session already gates them,
and starting the session still goes through it. hls/link stays limited.
tower_governor rounds the wait down to whole seconds, so with one token
a second every 429 carried retry-after: 0, and a client that honoured it
came straight back. The 429 now rounds up (at least 1 s), on the auth
limiter too.
Fixes #257
🤖 Generated with Claude Code
https://claude.ai/code/session_01KXE4e1KGijmQSLUde9ydBZ