-
Notifications
You must be signed in to change notification settings - Fork 495
fix: cap push notification configs per task #1181
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
ez-lbz
wants to merge
2
commits into
a2aproject:main
Choose a base branch
from
ez-lbz:fix/push-config-limit
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+110
−3
Open
Changes from all commits
Commits
Show all changes
2 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -7,11 +7,20 @@ | |
| PushNotificationConfigStore, | ||
| ) | ||
| from a2a.types.a2a_pb2 import TaskPushNotificationConfig | ||
| from a2a.utils.errors import InvalidParamsError | ||
|
|
||
|
|
||
| logger = logging.getLogger(__name__) | ||
|
|
||
|
|
||
| MAX_PUSH_NOTIFICATION_CONFIGS_PER_TASK = 50 | ||
| """Maximum number of push notification configs a single task may have. | ||
|
|
||
| Prevents a client from registering an unbounded number of webhooks for | ||
| one task (DoS / resource exhaustion). | ||
| """ | ||
|
|
||
|
|
||
| class InMemoryPushNotificationConfigStore(PushNotificationConfigStore): | ||
|
Collaborator
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. The push notification cap is only present in InMemoryPushNotificationConfigStore DatabasePushNotificationConfigStore and any custom PushNotificationConfigStore subclasses have no cap. I think that limit should belong at the handler layer, not in one store implementation. |
||
| """In-memory implementation of PushNotificationConfigStore interface. | ||
|
|
||
|
|
@@ -53,13 +62,33 @@ async def set_info( | |
| if not notification_config.id: | ||
| notification_config.id = task_id | ||
|
|
||
| # Enforce the per-task cap. Updating an existing config does not | ||
| # count as a new entry, so deduplicate before the check. | ||
| existing_configs = owner_infos[task_id] | ||
| is_update = any( | ||
| config.id == notification_config.id | ||
| for config in existing_configs | ||
| ) | ||
| if ( | ||
| not is_update | ||
| and len(existing_configs) | ||
| >= MAX_PUSH_NOTIFICATION_CONFIGS_PER_TASK | ||
| ): | ||
| raise InvalidParamsError( | ||
| message=( | ||
| f'maximum of ' | ||
| f'{MAX_PUSH_NOTIFICATION_CONFIGS_PER_TASK} push ' | ||
| 'notification configs per task exceeded' | ||
| ) | ||
| ) | ||
|
|
||
| # Remove existing config with the same ID | ||
| for config in owner_infos[task_id]: | ||
| for config in existing_configs: | ||
| if config.id == notification_config.id: | ||
| owner_infos[task_id].remove(config) | ||
| existing_configs.remove(config) | ||
| break | ||
|
|
||
| owner_infos[task_id].append(notification_config) | ||
| existing_configs.append(notification_config) | ||
| logger.debug( | ||
| 'Push notification config for task %s with config id %s for owner %s saved/updated.', | ||
| task_id, | ||
|
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'd avoid setting MAX_PUSH_NOTIFICATION_CONFIGS_PER_TASK just as a global constant. If this change lands it should be configurable, opt-in, with None default and set by some server config